Fix improper span closures on errors and LangchainCallbackHandler memory leaks#839
Closed
mpenn wants to merge 4 commits intoNVIDIA:developfrom
Closed
Fix improper span closures on errors and LangchainCallbackHandler memory leaks#839mpenn wants to merge 4 commits intoNVIDIA:developfrom
LangchainCallbackHandler memory leaks#839mpenn wants to merge 4 commits intoNVIDIA:developfrom
Conversation
…filerHandler - Introduced standardized error details capturing in IntermediateStepPayload with ErrorDetails model. - Updated Context class to emit success or error events based on function execution outcomes, including detailed error metadata. - Enhanced LangchainProfilerHandler to handle LLM and tool errors, pushing error events with relevant details to the step manager. - Added EventStatus enumeration to track the status of intermediate steps, improving observability in processing flows. This ensures proper nesting of spans, event in the event of tool call/llm/function invocation failures Signed-off-by: Matthew Penn <mpenn@nvidia.com>
Signed-off-by: Matthew Penn <mpenn@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…lbackHandler Signed-off-by: Matthew Penn <mpenn@nvidia.com>
Member
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
willkill07
added
the
Stale
|
This PR was closed because it has been stalled for 14 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes
This PR improves error handling during function invocation and llm/tool call failures in
LangchainCallbackHandlerto ensure proper closures of spans during export. This ensures proper nesting of traces. This includes an the following updates to theIntermediateStep:IntermediateStepPayload.statusattribute to represent invocation success/failureErrorDetailsto provide additional error details in the metadata attributeThis PR also resolves memory leaks in the
LangchainCallbackHandlerBy Submitting this PR I confirm: