Open
Conversation
Signed-off-by: Ivan Sorokin <27285181+1ytic@users.noreply.github.com>
dnandakumar-nv
requested changes
May 2, 2025
Contributor
dnandakumar-nv
left a comment
dnandakumar-nv
left a comment
There was a problem hiding this comment.
Could we please also add/modify the callback handler's unit tests to test the updated functionality? The tests can be found here:
mdemoret-nv
added
improvement
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Contributor
|
/ok to test b1264a9 |
Contributor
|
/ok to test 0eb8ea3 |
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Contributor
|
/ok to test b89738b |
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Contributor
|
/ok to test e08f3e1 |
willkill07
added
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store original tool inputs for TOOL_END event in LangchainProfilerHandler.