Fix preserving dataset merge for SFT#2218
Open
Bungmint wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
Conversation
yuki-97
reviewed
Apr 8, 2026
Contributor
There was a problem hiding this comment.
hi @Bungmint , thanks for helping fix this! left one minor comment.
you'll also need to:
- rebase main since your branch is a bit far from main (>10 will cause CI fail)
- fix DCO check: https://github.com/NVIDIA-NeMo/RL/pull/2218/checks?check_run_id=70050497521
| data_config[key] = default_data_config[key] | ||
|
|
||
|
|
||
| def merge_map_style_datasets(datasets: list[Any]) -> Any: |
Contributor
There was a problem hiding this comment.
nit: merge_map_style_datasets -> merge_datasets
Suggested change
| def merge_map_style_datasets(datasets: list[Any]) -> Any: | |
| def merge_datasets(datasets: list[Any]) -> Any: |
2 tasks
chtruong814
added
waiting-for-customer
chtruong814
added
the
waiting-on-customer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Heterogenous tool schema concatenation instead of calling the HuggingFace Datasets
concatenate_datasetsIssues
Closes the PR - (#2116):