Skip to content

feat: add preview review reference and update interactive iterate step#441

Open
johnnygreco wants to merge 7 commits intomainfrom
feat/skill-preview-review-reference
Open

feat: add preview review reference and update interactive iterate step#441
johnnygreco wants to merge 7 commits intomainfrom
feat/skill-preview-review-reference

Conversation

@johnnygreco
Copy link
Contributor

Summary

  • Add references/preview-review.md with structured guidance for reviewing dataset previews (diversity, data quality, design choices)
  • Update interactive workflow iterate step to offer self-review and reference the new guide
  • Remove stale "and serve again" wording from iterate step

@johnnygreco johnnygreco requested a review from a team as a code owner March 20, 2026 00:23
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 20, 2026

Greptile Summary

This PR adds a new references/preview-review.md guide providing structured criteria for reviewing dataset previews (diversity, data quality, design choices), and updates the interactive workflow's Iterate step to proactively offer self-review using that guide. It also removes stale "serve again" wording.

  • New reference guide (references/preview-review.md): Well-structured across three categories — Diversity (mode collapse, sampler effectiveness, structural monotony), Data Quality (instruction compliance, consistency, encoding, plausibility, judge calibration), and Design Choices — with a clear statistical-mindset framing.
  • Interactive workflow updated: Iterate step now breaks out into sub-bullets, adds an offer to self-review, and links to the new guide for guidance. The path references/preview-review.md resolution from within workflows/interactive.md was already flagged in a prior review thread.
  • Autopilot workflow not updated: The autopilot.md workflow also has a Preview step and a re-iterate path in its final Present step, but it does not reference the new review guide. If proactive self-review is valuable for interactive mode, it may be worth considering whether autopilot.md should also leverage the guide during its own iteration loop.

Confidence Score: 4/5

  • Safe to merge — documentation-only changes with no functional code impact.
  • The changes are purely additive documentation updates (a new reference guide and a wording improvement to the interactive workflow). No code logic is altered, no regressions are possible, and the guide content is accurate and well-structured. The one minor open question is whether the autopilot workflow should also reference the new guide, but that does not block this PR.
  • No files require special attention.

Important Files Changed

Filename Overview
skills/data-designer/references/preview-review.md New reference guide for reviewing dataset previews. Content is well-structured across three categories (Diversity, Data Quality, Design Choices) with clear mindset guidance. No issues found.
skills/data-designer/workflows/interactive.md Iterate step updated to add self-review offer and reference the new preview-review guide. The path references/preview-review.md may require careful resolution depending on how the agent resolves relative paths from this file's directory (already flagged in a previous review thread). The autopilot workflow is not updated with the same capability.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Step 6: Preview\nrun data-designer preview --save-results] --> B[Step 7: Iterate]
    B --> C[Ask user for feedback]
    B --> D[Offer self-review]
    D -->|User accepts| E[Read references/preview-review.md]
    E --> F{Review Categories}
    F --> G[Diversity\nMode collapse, sampler\neffectiveness, structural monotony]
    F --> H[Data Quality\nInstruction compliance, consistency,\nencoding, plausibility, judge calibration]
    F --> I[Design Choices\nColumn type appropriateness,\nsampler usage]
    G --> J[Suggest improvements]
    H --> J
    I --> J
    D -->|User declines| K[Apply user feedback]
    J --> K
    C --> K
    K --> L[Re-validate]
    L --> M[Re-preview]
    M --> N{User satisfied?}
    N -->|No| B
    N -->|Yes| O[Step 8: Finalize]
Loading

Last reviewed commit: "fix: clarify "the us..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant