feat: add preview review reference and update interactive iterate step#441
Open
johnnygreco wants to merge 7 commits intomainfrom
Open
feat: add preview review reference and update interactive iterate step#441johnnygreco wants to merge 7 commits intomainfrom
johnnygreco wants to merge 7 commits intomainfrom
Conversation
Contributor
Greptile SummaryThis PR adds a new
|
| Filename | Overview |
|---|---|
| skills/data-designer/references/preview-review.md | New reference guide for reviewing dataset previews. Content is well-structured across three categories (Diversity, Data Quality, Design Choices) with clear mindset guidance. No issues found. |
| skills/data-designer/workflows/interactive.md | Iterate step updated to add self-review offer and reference the new preview-review guide. The path references/preview-review.md may require careful resolution depending on how the agent resolves relative paths from this file's directory (already flagged in a previous review thread). The autopilot workflow is not updated with the same capability. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Step 6: Preview\nrun data-designer preview --save-results] --> B[Step 7: Iterate]
B --> C[Ask user for feedback]
B --> D[Offer self-review]
D -->|User accepts| E[Read references/preview-review.md]
E --> F{Review Categories}
F --> G[Diversity\nMode collapse, sampler\neffectiveness, structural monotony]
F --> H[Data Quality\nInstruction compliance, consistency,\nencoding, plausibility, judge calibration]
F --> I[Design Choices\nColumn type appropriateness,\nsampler usage]
G --> J[Suggest improvements]
H --> J
I --> J
D -->|User declines| K[Apply user feedback]
J --> K
C --> K
K --> L[Re-validate]
L --> M[Re-preview]
M --> N{User satisfied?}
N -->|No| B
N -->|Yes| O[Step 8: Finalize]
Last reviewed commit: "fix: clarify "the us..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/preview-review.mdwith structured guidance for reviewing dataset previews (diversity, data quality, design choices)