feat: resolve data-designer command path before workflow execution#440
Open
johnnygreco wants to merge 7 commits intomainfrom
Open
feat: resolve data-designer command path before workflow execution#440johnnygreco wants to merge 7 commits intomainfrom
johnnygreco wants to merge 7 commits intomainfrom
Conversation
Ensure the skill locates the data-designer binary (PATH or .venv) up front so all subsequent commands use the correct path.
Contributor
Greptile SummaryThis PR adds a two-line "Before You Start" instruction to
|
| Filename | Overview |
|---|---|
| skills/data-designer/SKILL.md | Adds a pre-flight command resolution step to find the data-designer binary via which with a .venv/bin/ fallback using test -x + realpath; logic is sound and previous review issues are addressed. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["/data-designer skill invoked"] --> B["Run resolution command:\nwhich data-designer 2>/dev/null\n|| (test -x .venv/bin/data-designer\n&& realpath .venv/bin/data-designer)"]
B --> C{which succeeds?}
C -- "Yes → path printed" --> D["data-designer is on PATH\nUse bare 'data-designer' command normally"]
C -- "No" --> E{test -x .venv/bin/data-designer?}
E -- "Yes → realpath prints abs path" --> F["Store absolute path\nUse it for ALL subsequent\ndata-designer commands"]
E -- "No" --> G["Neither path works\n→ Troubleshooting section"]
D --> H["Load workflow\n(interactive.md or autopilot.md)"]
F --> H
H --> I["data-designer agent context\ndata-designer validate ...\ndata-designer preview ...\ndata-designer create ..."]
Last reviewed commit: "fix: use test -x to ..."
Address review feedback: ls outputs a relative path that breaks if the working directory changes. Use realpath to get an absolute path instead.
GNU realpath exits 0 for non-existent paths, so add a test -f check to ensure the fallback only produces output when the file exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
which data-designerand falls back to.venv/bin/data-designer, ensuring all subsequent commands use the correct pathTest plan
/data-designerand verify the command resolution runs before any workflow stepsdata-designeris only in.venv/bin/(not on PATH) to confirm the fallback works