-
Notifications
You must be signed in to change notification settings - Fork 52
feat: MCP (Model Context Protocol) tool calling integration for LLM columns #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eric-tramel
wants to merge
11
commits into
main
Choose a base branch
from
feat/mcp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinchha
reviewed
Jan 27, 2026
packages/data-designer-engine/src/data_designer/engine/models/facade.py
Outdated
Show resolved
Hide resolved
nabinchha
reviewed
Jan 27, 2026
packages/data-designer-engine/src/data_designer/engine/models/facade.py
Outdated
Show resolved
Hide resolved
824d8ed to
177d38d
Compare
eric-tramel
commented
Jan 27, 2026
packages/data-designer-engine/src/data_designer/engine/mcp/manager.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces Model Context Protocol (MCP) integration into Data Designer, enabling LLM generation columns to call external tools via MCP servers. This allows models to dynamically retrieve information, perform calculations, or interact with external systems during data generation.
TODO
Key Features
DataDesignerlevel, supporting both stdio (command-based) and SSE (URL-based) transportsModelFacadehandles iterative tool calling until the model produces a final responsemax_tool_callsprevents runaway tool loopsNew Configuration Types
MCPServerConfigDefines how to connect to an MCP server:
MCPToolConfigControls which tools an LLM column may use:
Usage Example
Full Message Traces (
*__trace)This PR replaces the previous
{column_name}__reasoning_traceside-effect column with a more powerful{column_name}__tracecolumn.{column_name}__reasoning_trace(reasoning only, when the provider exposed it){column_name}__trace(full ordered message history)What is stored
When enabled,
{column_name}__traceis alist[dict]containing the complete message history for the final generation attempt, including (in order):tool_calls)role="tool",tool_call_id,content)If the model/provider exposes it, assistant messages may also include a
reasoning_contentfield.How to enable
Traces are controlled via a new runtime option:
Architecture
New Files
packages/data-designer-config/src/data_designer/config/mcp.pyMCPServerConfigandMCPToolConfigPydantic modelspackages/data-designer-engine/src/data_designer/engine/mcp/manager.pyMCPClientManager- connects to servers, caches tools, executes callspackages/data-designer-engine/src/data_designer/engine/mcp/errors.pyModified Files
packages/data-designer-config/src/data_designer/config/column_configs.pytool_configfield toLLMTextColumnConfigpackages/data-designer-config/src/data_designer/config/run_config.pyinclude_full_tracesto enable{column_name}__tracepackages/data-designer-engine/src/data_designer/engine/models/facade.pypackages/data-designer-engine/src/data_designer/engine/models/factory.pymcp_managertoModelFacadepackages/data-designer-engine/src/data_designer/engine/resources/resource_provider.pyMCPClientManagerpackages/data-designer/src/data_designer/interface/data_designer.pymcp_serversparameterTest Plan
MCPServerConfigvalidation (packages/data-designer-config/tests/config/test_mcp.py)MCPClientManager(packages/data-designer-engine/tests/engine/mcp/test_manager.py)ModelFacadetool calling (packages/data-designer-engine/tests/engine/models/test_facade.py)tests_e2e/tests/test_mcp_demo.py)Running the E2E Demo
# Requires NVIDIA_API_KEY environment variable NVIDIA_API_KEY=your-key uv run pytest tests_e2e/tests/test_mcp_demo.py -vDependencies
mcppackage topackages/data-designer-engine/pyproject.toml(provides MCP client functionality)