chore: add publishing script #241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnygreco
changed the title
| upload_to_pypi() { | ||
| header "Uploading to PyPI" | ||
|
|
||
| if [[ "$DRY_RUN" == true ]]; then |
Contributor
There was a problem hiding this comment.
We could maybe go a bit beyond when dry running? There is e.g. , twine check, twine --dry-run and testpypi
Contributor
Author
There was a problem hiding this comment.
Thanks @andreatgretel! Adding the testpypi option revealed some subtle issues (e.g., the readme that gets published for the data-designer subpackage should be the top-level readme).
Contributor
|
Are we still thinking of maybe doing any of this on CI, or is the script enough? I tend to think the script is enough. |
andreatgretel
previously approved these changes
Jan 27, 2026
- Fix sed regex for macOS compatibility: use -E flag with extended regex instead of \? which BSD sed interprets as literal - Optimize TestPyPI mode to build only once by creating tag first - Extract verify_package_versions() into reusable function - Separate flows for dry-run, TestPyPI, and production modes
johnnygreco
force-pushed
the
johnny/chore/add-publish-script
branch
from
f0831d0 to
1e18e1e
Compare
Contributor
Author
Yeah, maybe we start with this script + make and see if that works for us. |
johnnygreco
force-pushed
the
johnny/refactor/207-repackaging-with-subpackages
branch
from
824d8ed to
177d38d
Compare
* add municipality to person fields * update brazil fields * add locales * fix file size * Update dataset_based_person_fields.py Co-authored-by: Andre Manoel <165937436+andreatgretel@users.noreply.github.com> * update to ngc sizes --------- Co-authored-by: Andre Manoel <165937436+andreatgretel@users.noreply.github.com>
* feat: Add /create-pr skill for well-formatted GitHub PRs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: Add guidance for including links to code and commits in PRs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: Change skill arguments to freeform special instructions Allows users to provide any guidance like base branch, summary focus, or additional context rather than rigid branch-or-title detection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: Disable model invocation for skills Add disable-model-invocation: true to create-pr and new-sdg skills so they only run when explicitly invoked by the user via /skill-name. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* remove colon * update person sampling docs
* remove old structure * major shuffle * streamline project configs * update make commands * updates to make commands * remove essentials * initialize logger in interface * uv lock * ignore notepad * update workflows * fix e2e project config * generate colab notebooks * resolve default model settings in interface * fix build commands * update perf import make command * cleaning up some slop * update recipes * move conftest files to tests/ * update subpackage readmes * streamline config_logging * use exports * update perf import usage pattern * update for IDE behavior with ruff * remove engine's fixtures file * add note to about lazy imports * update dependencies * update docs * doc fixes * uv lock * updates to catch up with main * clean up makefile * remove package gitignores * define deps only once * isolate tests * add test for protetion rule * create temp dirs for isolated tests * catch up to main * update headers * re apply changes * better result summaries for isolated tests * move exports into top-level init * fix client importlib version syntax * catch up with main
johnnygreco
changed the base branch from
johnny/refactor/207-repackaging-with-subpackages
to
main
johnnygreco
dismissed stale reviews from andreatgretel and nabinchha
The base branch was changed.
Contributor
Author
|
closed in favor of #253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new automated publishing workflow for the project, making it easier and safer to publish all packages to PyPI with consistent versioning. It adds a robust
publishcommand to theMakefile, along with a comprehensivescripts/publish.shscript that handles validation, testing, building, tagging, and uploading. Additionally, the license header update script is improved to support both Python and shell script files.Automated Publishing Workflow:
publishcommand to theMakefilethat supports versioning, dry-run, and branch control options, and updated the help text to document these features. [1] [2] [3]scripts/publish.sh, a robust script that automates the full PyPI publishing process for all packages, including argument parsing, validation (version format, branch, git state, PyPI credentials), running tests, building packages, tagging, uploading, and reporting. Supports dry-run and branch override.License Header Tool Improvements:
scripts/update_license_headers.pyto support both.pyand.shfiles, ensuring license headers are present and up-to-date in Python and shell scripts. Updated processing logic, supported extensions, and CLI help text. [1] [2] [3] [4]