Conversation
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
HuiyingLi
requested review from
adil-a,
akoumpa,
hemildesai,
oliverholworthy,
rnyak,
shan-nvidia and
ybabakhin
as code owners
Contributor
|
/ok to test f121ab8 |
Contributor
|
/ok to test 2e1ef97 |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
|
/ok to test 49e9659 |
Contributor
Author
|
/ok to test 00f6232 |
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/ok to test d213273 |
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/ok to test b536c20 |
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/ok to test 32a053c |
hemildesai
reviewed
Jan 28, 2026
| if include_multimodal_encoders: | ||
| stage_modules.extend([f"{fqn_prefix}{suffix}" for suffix in MULTIMODAL_SUFFIXES]) | ||
| if extra_module_fqns: | ||
| stage_modules.extend(extra_module_fqns) |
Contributor
There was a problem hiding this comment.
Can you combine this into one parent if stage_idx == 0:?
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/ok to test b988015 |
Contributor
Author
|
/ok to test e2788cd |
hemildesai
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.