Skip to content

Save and load SOK model embeddings#951

Open
wenjing-nv wants to merge 28 commits into
mainfrom
fea-sok-load-dump
Open

Save and load SOK model embeddings#951
wenjing-nv wants to merge 28 commits into
mainfrom
fea-sok-load-dump

Conversation

@wenjing-nv

@wenjing-nv wenjing-nv commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

Fixes # (issue)

Goals ⚽

Provide an interfact for SOKEmbedding load/dump and a sample code for SOKEmbedding model load/dump

Implementation Details 🚧

Testing Details 🔍

This ticket is about saving and loading a model trained with SOK. this might take 1 or two releases.

@github-actions

Copy link
Copy Markdown

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-951

@rnyak rnyak added this to the Merlin 23.02 milestone Jan 18, 2023
@rnyak rnyak requested review from edknv and marcromeyn January 18, 2023 15:51
@rnyak

rnyak commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

related PR: #863

@rnyak rnyak modified the milestones: Merlin 23.02, Merlin 23.03 Feb 13, 2023
@rnyak

rnyak commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

@WonderingWJ is this the duplicate of #863? shall we remove this one or keep both, bcs both are required? could you please provide some info? thanks.

@wenjing-nv

Copy link
Copy Markdown
Contributor Author

@rnyak This one is not a duplication of #863. This one targets to solve the load/dump for SOK. That one is to integrate SOK into merlin models

@rnyak

rnyak commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

@WonderingWJ is this still WIP or this is ready? could you update your branch? thanks.

@rnyak

rnyak commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

@WonderingWJ any update on that PR? can we close it?

@edknv

edknv commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

@WonderingWJ Is this PR still relevant? If so, we will need to rebase this PR.

@wenjing-nv

Copy link
Copy Markdown
Contributor Author

@WonderingWJ Is this PR still relevant? If so, we will need to rebase this PR.

The dump/load method of SOK is under development. After SOK load/dump is done, we can discuss this MR. Currently, we don't need to rebase. Thank you!

@wenjing-nv

Copy link
Copy Markdown
Contributor Author

@WonderingWJ any update on that PR? can we close it?

Sorry for late response. The SOK load/dump is under development. Currently, we can keep this MR and discuss it after SOK load/dump is done.

@rnyak rnyak modified the milestones: Merlin 23.03, Merlin 23.04 Mar 27, 2023
@karlhigley karlhigley changed the title Fea sok load dump Save and load SOK model embeddings May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants