Feature/bcss 23189 add new modules to suppport bcss#23
Open
nhs-oliverslater wants to merge 14 commits into
Open
Feature/bcss 23189 add new modules to suppport bcss#23nhs-oliverslater wants to merge 14 commits into
nhs-oliverslater wants to merge 14 commits into
Conversation
…sections in readme files
…updated labelling and naming convention within module BREAKING CHANGE: This changes the tag and naming output format to be able to be utilised by other modules. This will change resource naming and may result in resource re-creation.
…sections in readme files
…r not yet used locals
…ile for use with other modules
…order Update described defaults to reflect main.tf - Defaults to ["service", "project", "environment", "stack", "name", "attributes"]
…ce for input{ region }
data.aws_region.current.name => data.aws_region.current.region
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region
…ed tag 'public_facing' to string Generated tags uses length() which expects all tags_context to be a string, a collection type, or a structural type. var.public_facing is a bool, so have wrapped this in a tostring().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.