Skip to content

CCM-8354: NHS App test message details#945

Merged
andykay-nhs merged 46 commits into
mainfrom
feature/CCM-8354-nhs-app-digital-proofing
May 19, 2026
Merged

CCM-8354: NHS App test message details#945
andykay-nhs merged 46 commits into
mainfrom
feature/CCM-8354-nhs-app-digital-proofing

Conversation

@nicki-nhs
Copy link
Copy Markdown
Contributor

@nicki-nhs nicki-nhs commented May 6, 2026

Description

  • Creates send-test-nhs-app-message page
  • Creates SendTestMessage component which will be used for the other digital channels
  • Creates TestPersonalisationForm and CustomFieldsForm components
  • Refactors letter authoring to use the above components
  • Adds util for NHS number validation
  • Updates MarkdownContent to merge overrides on links
  • Adds customPersonalisation and systemPersonalisation to schema for digital templates
  • Extends functionality of template factory test helper
  • Updates template repository to save custom and system personalisation to the DB when creating/updating templates
send-test-nhs-app-message-custom-fields-initial-load send-test-nhs-app-message-custom-fields-initial-errors

Context

Allows users to enter the details to request digital proofs of their NHS App templates

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nicki-nhs nicki-nhs requested a review from a team as a code owner May 6, 2026 13:57
@nicki-nhs nicki-nhs changed the title CCM-8354 NHS App digital proofing CCM-8354: NHS App digital proofing May 6, 2026
@nicki-nhs nicki-nhs changed the title CCM-8354: NHS App digital proofing CCM-8354: NHS App test message details May 6, 2026
Comment thread infrastructure/terraform/modules/backend-api/spec.tmpl.json Outdated
Comment thread frontend/src/app/send-test-nhs-app-message/[templateId]/page.tsx
Comment thread frontend/src/components/forms/SendTestMessage/server-action.ts Outdated
@alexnuttall
Copy link
Copy Markdown
Contributor

I think you need updates in update-template.api.spec.ts and create-template.api.spec.ts to cover the new field behaviours

Comment thread tests/test-team/template-mgmt-api-tests/update-template.api.spec.ts
andykay-nhs
andykay-nhs previously approved these changes May 19, 2026
andykay-nhs
andykay-nhs previously approved these changes May 19, 2026
alexnuttall
alexnuttall previously approved these changes May 19, 2026
@nicki-nhs nicki-nhs dismissed stale reviews from alexnuttall and andykay-nhs via 0203fd5 May 19, 2026 10:47
@andykay-nhs andykay-nhs merged commit 4e5fb9e into main May 19, 2026
45 checks passed
@andykay-nhs andykay-nhs deleted the feature/CCM-8354-nhs-app-digital-proofing branch May 19, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants