Open
Conversation
alexnuttall
reviewed
Mar 16, 2026
infrastructure/terraform/modules/backend-api/dynamodb_table_proof_requests.tf
Outdated
Show resolved
Hide resolved
alexnuttall
previously approved these changes
Mar 16, 2026
nicki-nhs
reviewed
Mar 16, 2026
Comment on lines
+8
to
+13
| id: z.string().regex(UUID_REGEX).meta({ | ||
| description: 'Unique identifier of the proof request', | ||
| }), | ||
| templateId: z.string().regex(UUID_REGEX).meta({ | ||
| description: 'Unique identifier for the template being proofed', | ||
| }), |
Contributor
There was a problem hiding this comment.
Suggested change
| id: z.string().regex(UUID_REGEX).meta({ | |
| description: 'Unique identifier of the proof request', | |
| }), | |
| templateId: z.string().regex(UUID_REGEX).meta({ | |
| description: 'Unique identifier for the template being proofed', | |
| }), | |
| id: z.uuidv4().meta({ | |
| description: 'Unique identifier of the proof request', | |
| }), | |
| templateId: z.uuidv4().meta({ | |
| description: 'Unique identifier for the template being proofed', | |
| }), |
?
Contributor
Author
There was a problem hiding this comment.
yeah good shout - z.uuid actually uses the same regex we are using in code.
Contributor
Author
There was a problem hiding this comment.
Actually - it was the EventEnvelope.subject that used the same regex which uses z.uuid. I'm unsure why we're using a custom regex for UUID.
^[\\dA-Fa-f]{8}(?:-[\\dA-Fa-f]{4}){3}-[\\dA-Fa-f]{12}$ - seems to just "verify" that the string is a uuid shape whereas z.uuid is much stricter.
Contributor
Author
There was a problem hiding this comment.
We've been using this custom uuid regex for all our event data fields.
nicki-nhs
reviewed
Mar 16, 2026
nicki-nhs
reviewed
Mar 16, 2026
| @@ -0,0 +1,12 @@ | |||
| module "sqs_proof_requests_table_events_pipe_dlq" { | |||
| source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.28/terraform-sqs.zip" | |||
Contributor
There was a problem hiding this comment.
use latest version?
chris-elliott-nhsd
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.