CCM-13493: letter details #815
Open
+5,045
−1,329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page-letter-details
- Add missing .missingValue CSS class for highlighting empty campaign - Rename showEditCampaignLink to hideEditCampaignLink for clarity - Extract reusable ActionLink component to reduce duplication - Move hardcoded external URLs to content.ts - Add external link support (target=_blank, rel=noopener noreferrer) - Add E2E tests for campaign auto-selection behavior - Update snapshots to reflect external link attributes
alexnuttall
force-pushed
the
feature/CCM-13493-page-letter-details
branch
from
0f7943d to
93e86b9
Compare
bhansell1
reviewed
Feb 3, 2026
...nd/src/components/molecules/PreviewTemplateDetails/PreviewTemplateDetailsAuthoringLetter.tsx
Show resolved
Hide resolved
bhansell1
reviewed
Feb 3, 2026
| "@types/js-cookie": "^3.0.6", | ||
| "@types/jsonwebtoken": "^9.0.9", | ||
| "@types/markdown-it": "^13.0.9", | ||
| "@types/node": "^22.13.12", |
Contributor
Author
There was a problem hiding this comment.
I meant to move it into the root package JSON (have just updated). Just thinking it should be everywhere or only in the root package, rather than just in frontend
Contributor
There was a problem hiding this comment.
er.... maybe just in the root? 🤷 . I don't see any harm in it being in the other places either.
bhansell1
reviewed
Feb 3, 2026
frontend/src/__tests__/components/molecules/__snapshots__/ChannelTemplates.test.tsx.snap
Show resolved
Hide resolved
bhansell1
reviewed
Feb 3, 2026
frontend/src/components/organisms/PreviewLetterTemplate/PreviewLetterTemplate.tsx
Outdated
Show resolved
Hide resolved
bhansell1
reviewed
Feb 3, 2026
...te-mgmt-component-tests/letter/template-mgmt-preview-submitted-letter-page.component.spec.ts
Outdated
Show resolved
Hide resolved
bhansell1
reviewed
Feb 3, 2026
| await expect(previewLargePrintLetterTemplatePage.summaryList).toBeVisible(); | ||
|
|
||
| if (!templates.AUTHORING_LARGE_PRINT_LETTER.campaignId) { | ||
| throw new Error('Test data misconfiguration'); |
bhansell1
reviewed
Feb 3, 2026
| ).toBeVisible(); | ||
|
|
||
| if (!templates.AUTHORING_FRENCH_LETTER.campaignId) { | ||
| throw new Error('Test data misconfiguration'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a letter details table for AUTHORING letters. This is visible on the
preview-letter-templatepage also onpreview-submitted-templateand the message-planspreview-templatepages in different variationspreview: status is
NOT_YET_SUBMITTEDpreview-submitted:
preview under 'message-plans':
The
typerow being changed toTemplate typeacross all channels is intentional and agreed with content designersContext
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.