generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
CCM-13493: letter version #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhansell1
reviewed
Feb 2, 2026
bhansell1
reviewed
Feb 2, 2026
bhansell1
previously approved these changes
Feb 2, 2026
ClareJonesBJSS
approved these changes
Feb 2, 2026
jamesthompson26-nhs
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is intended to lay some groundworks for carbone letters by making letter templates a discriminated union type where the discriminator is
letterVersionwhich isPDForAUTHORING.There are no functional changes at all, apart from saving the
letterVersionfield to the database on new letters, and adding it to API responses for letters.If a database record doesn't have the field, it's added as a default at the zod parsing stage in the API.
It's not possible to create AUTHORING letters via the API so the frontend can assume that they won't be seen anywhere yet.
The type only includes the fields needed to implement the details pane (
sidesCount,letterVariantId), not anything related to files or renders yet.Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.