Feature/ccm 15186 queue metrics#462
Open
stevebux wants to merge 3 commits intofeature/CCM-13906-Urgent-Letter-Priorityfrom
Open
Feature/ccm 15186 queue metrics#462stevebux wants to merge 3 commits intofeature/CCM-13906-Urgent-Letter-Priorityfrom
stevebux wants to merge 3 commits intofeature/CCM-13906-Urgent-Letter-Priorityfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces queue-size delta metrics for the update-letter-queue Lambda (used to maintain the pending letters queue table from the letters change stream), alongside dependency/lockfile updates.
Changes:
- Emit CloudWatch EMF metrics for per-supplier pending-queue deltas (
QueueDelta) fromupdate-letter-queue. - Refactor queue update helpers to return numeric deltas (0/1) and aggregate per supplier across a batch.
- Update dependency locks/overrides (npm overrides for
flatted/undici, and bumppyjwtin e2e Poetry lock).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e-tests/poetry.lock | Updates locked pyjwt version for e2e test environment. |
| package.json | Adds npm overrides entries for flatted and undici. |
| package-lock.json | Updates resolved versions for flatted/undici per overrides. |
| lambdas/update-letter-queue/src/update-letter-queue.ts | Adds per-supplier queue delta metric aggregation and emission. |
| lambdas/update-letter-queue/src/tests/update-letter-queue.test.ts | Updates/extends unit tests to assert QueueDelta metric behavior and new edge-case handling. |
You can also share your feedback on Copilot code review. Take the survey.
lambdas/update-letter-queue/src/__tests__/update-letter-queue.test.ts
Outdated
Show resolved
Hide resolved
lambdas/update-letter-queue/src/__tests__/update-letter-queue.test.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.