generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/ccm 13906 urgent letter priority #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stevebux
wants to merge
7
commits into
feature/CCM-13116-Letter-Queue-Operations
Choose a base branch
from
feature/CCM-13906-Urgent-Letter-Priority
base: feature/CCM-13116-Letter-Queue-Operations
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0d85318
Delete from letter queue when letter no longer pending
stevebux 6e1f953
Fix vulnerabilities
stevebux 3480224
Fix test
stevebux 9f42fb0
Introduce visibility timeout
stevebux 3e57a92
Rename visibilityTimeout to visibilityTimestamp
stevebux b642dac
Linting fix
stevebux 6c44dc5
CCM-13906 Urgent Letter Priority
stevebux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ export async function setupDynamoDBContainer() { | |
| accessKeyId: "fakeMyKeyId", | ||
| secretAccessKey: "fakeSecretAccessKey", | ||
| }, | ||
| maxAttempts: 1, | ||
| }); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is to prevent failing tests from retrying multiple times, and then hitting the 30 second timeout |
||
|
|
||
| const docClient = DynamoDBDocumentClient.from(ddbClient); | ||
|
|
@@ -129,10 +130,10 @@ const createLetterQueueTableCommand = new CreateTableCommand({ | |
| ], | ||
| LocalSecondaryIndexes: [ | ||
| { | ||
| IndexName: "timestamp-index", | ||
| IndexName: "queueSortOrder-index", | ||
| KeySchema: [ | ||
| { AttributeName: "supplierId", KeyType: "HASH" }, // Partition key for LSI | ||
| { AttributeName: "queueTimestamp", KeyType: "RANGE" }, // Sort key for LSI | ||
| { AttributeName: "queueSortOrderSk", KeyType: "RANGE" }, // Sort key for LSI | ||
| ], | ||
| Projection: { | ||
| ProjectionType: "ALL", | ||
|
|
@@ -142,7 +143,7 @@ const createLetterQueueTableCommand = new CreateTableCommand({ | |
| AttributeDefinitions: [ | ||
| { AttributeName: "supplierId", AttributeType: "S" }, | ||
| { AttributeName: "letterId", AttributeType: "S" }, | ||
| { AttributeName: "queueTimestamp", AttributeType: "S" }, | ||
| { AttributeName: "queueSortOrderSk", AttributeType: "S" }, | ||
| ], | ||
| }); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /** | ||
| * Error thrown when attempting to delete a letter that does not exist in the database. | ||
| */ | ||
| // eslint-disable-next-line import-x/prefer-default-export | ||
| export class LetterDoesNotExistError extends Error { | ||
| constructor( | ||
| public readonly supplierId: string, | ||
| public readonly letterId: string, | ||
| ) { | ||
| super( | ||
| `Letter does not exist: supplierId=${supplierId}, letterId=${letterId}`, | ||
| ); | ||
| this.name = "LetterDoesNotExistError"; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.