Feature/ccm 17641 reporting failure#345
Conversation
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
from
b1a99c8 to
8a9fef3
Compare
| uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5 | ||
| - name: "Build docs" | ||
| uses: NHSDigital/nhs-notify-shared-modules/.github/actions/build-docs@3.0.0 | ||
| uses: NHSDigital/nhs-notify-shared-modules/.github/actions/build-docs@3.1.6 |
There was a problem hiding this comment.
To use latest NHSDigital/nhs-notify-shared-modules#195
| $ref: ../defs/core.schema.yaml#/properties/failureCode | ||
| failureReason: | ||
| $ref: ../defs/core.schema.yaml#/properties/failureReason | ||
| reasonCode: |
| { | ||
| "devDependencies": { | ||
| "@nhsdigital/nhs-notify-event-schemas-status-published": "^1.0.1", | ||
| "@nhsdigital/nhs-notify-event-schemas-status-published": "^1.0.2", |
There was a problem hiding this comment.
Contract tests started to failed, so taking the latest one
There was a problem hiding this comment.
Should we also have a test for when the NHSApp message fails due to the patient not being a registered app user (where the status is Rejected)?
There was a problem hiding this comment.
As discussed, from the reporting point of view the channel still marked as Failed but we want to add scenarios where the reasoncode and text are different (to simulate what we get from CCM-17639) , so I'll update the event-builder for this and add another scenario.
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
from
d8b880a to
e31ed22
Compare
| [EventStatus.DigitalLetterNhsAppUnsuccessful], | ||
| 'Failed', | ||
| senderId, | ||
| 'DL_INTE_001', |
There was a problem hiding this comment.
Unless I'm mistaken reasonCode will be a notify error code in real life. We might want to use something other than DL_INTE in tests to avoid confusion. I believe we are going to get rid of the DL failure code DL_INTE_001 in the future as it won't be used for anything (we will use the code from Core instead).
| [EventStatus.DigitalLetterNhsAppUnsuccessfulOtherReason], | ||
| 'Failed', | ||
| senderId, | ||
| 'DL_INTE_002', |
| [EventStatus.Unread, EventStatus.DigitalLetterNhsAppUnsuccessful], | ||
| 'Failed', | ||
| senderId, | ||
| 'DL_INTE_001', |
| time: string, | ||
| messageReference: string, | ||
| senderId: string, | ||
| reasonCode = 'DL_INTE_001', |
…emas-status-published) is outdated
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
from
e31ed22 to
5dfef2c
Compare
4 participants
Description
See comment
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.