CCM-14974: Additional failure events in CSV reports#245
Open
ScottFullerton-NHSE wants to merge 13 commits intomainfrom
Open
CCM-14974: Additional failure events in CSV reports#245ScottFullerton-NHSE wants to merge 13 commits intomainfrom
ScottFullerton-NHSE wants to merge 13 commits intomainfrom
Conversation
Bumps [h3](https://github.com/h3js/h3) from 1.15.5 to 1.15.8. - [Release notes](https://github.com/h3js/h3/releases) - [Changelog](https://github.com/h3js/h3/blob/main/CHANGELOG.md) - [Commits](h3js/h3@v1.15.5...v1.15.8) --- updated-dependencies: - dependency-name: h3 dependency-version: 1.15.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
simonlabarere
left a comment
simonlabarere
left a comment
There was a problem hiding this comment.
A few comments, sorry!
infrastructure/terraform/components/dl/scripts/sql/reports/daily_report.sql
Outdated
Show resolved
Hide resolved
infrastructure/terraform/components/dl/scripts/sql/reports/daily_report.sql
Outdated
Show resolved
Hide resolved
tests/playwright/digital-letters-component-tests/report-generator.component.spec.ts
Show resolved
Hide resolved
tdroza-nhs
requested changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
I was expecting to see a failureCode/message being set for these new statuses. e.g. for the FileQuarantined event we'd have a failurecode/message that says something about a virus being detected.
I don't see that in the story though - would be good to clarify that with TomH to see if it's covered by another story or should be in this one
Contributor
Author
There was a problem hiding this comment.
Will catch up on Monday with Tom H to discuss this. We're happy for the ticket to progress in the time being until then.
…-reports-failure-events # Conflicts: # package-lock.json # src/eventcatalog/package-lock.json # src/eventcatalog/package.json
…tcatalog/h3-1.15.8' into feature/CCM-14974-csv-reports-failure-events
simonlabarere
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added 4 existing events to the failure report:
I've also included a fix for the current trivy vulnerabilities - including pulling in one of dependabot's PRs.
Context
These events could lead to a failure, and we want to send comprehensive reports to trusts, so they understand why a request might have failed.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.
CSV From the component tests:
https://820178564574-oocgiqa6.eu-west-2.console.aws.amazon.com/s3/object/nhs-820178564574-eu-west-2-pr245-dl-reporting?region=eu-west-2&prefix=event-reports/report-generator-test-b9345bbf-998f-45ac-99bb-cb72bf104042/completed_communications/completed_communications_2026-03-18.csv