CCM-13475: Send print events by simonlabarere · Pull Request #179 · NHSDigital/nhs-notify-digital-letters

simonlabarere · 2026-01-13T13:22:31Z

Description

Create new Print Sender component that triggers a Letter Prepared Event to be eventually passed to the Supplier API from a Letter Analysed Event.

Contains changes from #174 to pull packages from GitHub.

Note: When merging main, @nhsdigital/nhs-notify-event-schemas-supplier-api was updated to 1.0.10, which introduces a breaking change requiring billingRef in the events. As this change is not yet supported, the dependency has been temporarily pinned to 1.0.6.

Test evidence

Print Sender logs

Event Bus logs

Input Letter Analysed event + Output Letter Prepared event

Event is published to the cross domain event bus

Type of changes

Refactoring (non-breaking change)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would change existing functionality)
Bug fix (non-breaking change which fixes an issue)

Checklist

I am familiar with the contributing guidelines
I have followed the code style of the project
I have added tests to cover my changes
I have updated the documentation accordingly
This PR is a result of pair or mob programming
If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

infrastructure/terraform/components/dl/cloudwatch_event_rule_letter_prepared.tf

nhsd-angel-pastor · 2026-01-15T10:52:51Z

infrastructure/terraform/components/dl/module_sqs_print_sender.tf

+    ]
+
+    resources = [
+      "arn:aws:sqs:${var.region}:${var.aws_account_id}:${var.project}-${var.environment}-${local.component}-print-sender-queue"


tiny one, is it worth using ${local.csi} instead of ${var.project}-${var.environment}-${local.component}? from the file terraform/components/dl/locals_tfscaffold.tf:

csi = replace(
format(
"%s-%s-%s",
var.project,
var.environment,
local.component,
),
"_",
"",
)

lambdas/print-sender-lambda/src/app/print-sender.ts

infrastructure/terraform/components/dl/modules_eventpub.tf

lambdas/print-sender-lambda/src/app/print-sender.ts

….0.6

tests/playwright/digital-letters-component-tests/print-sender.component.spec.ts

nhsd-angel-pastor · 2026-01-30T08:56:56Z

infrastructure/terraform/components/dl/modules_eventpub.tf

+module "eventpub" {
+  source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.30/terraform-eventpub.zip"
+
+  name = "eventpub"


is this how we expose the events to the digital letters API? just wondering if the name should be a bit more descriptive.

docs/package-lock.json

lambdas/print-sender-lambda/package.json

lambdas/print-sender-lambda/src/__tests__/app/print-sender.test.ts

lambdas/print-sender-lambda/src/apis/sqs-trigger-lambda.ts

lambdas/print-sender-lambda/src/__tests__/apis/sqs-trigger-lambda.test.ts

infrastructure/terraform/components/dl/module_sqs_print_sender.tf

…validate-private-key.test.ts

gareth-allan

A couple of last comments, but it otherwise looks good!

gareth-allan · 2026-02-02T15:22:39Z

infrastructure/terraform/components/dl/module_sqs_print_sender.tf


-  create_dlq = true
+  create_dlq        = true
+  max_receive_count = 1


Why set the max receive count to 1 for this lambda? Do we not want to benefit from automatic retries before sending a message to the DLQ?

gareth-allan · 2026-02-02T16:33:32Z

tests/playwright/constants/backend-constants.ts

 export const HANDLE_TTL_DLQ_NAME = `${CSI}-ttl-handle-expiry-errors-queue`;
 export const PRINT_ANALYSER_DLQ_NAME = `${CSI}-print-analyser-dlq`;
+export const PRINT_SENDER_DLQ_NAME = `${CSI}-print-sender-dlq`;
+export const EVENT_PUBLISHER_DLQ_NAME = `${CSI}-event-publisher-errors`;


Is EVENT_PUBLISHER_DLQ_NAME used anywhere?

simonlabarere requested review from a team as code owners January 13, 2026 13:22

simonlabarere and others added 3 commits January 13, 2026 13:31

CCM-13475: Send print events

b96894d

CCM-12614: add github package manager authentication

b47da0a

CCM-12614: add github package manager authentication

d9a4b1a

simonlabarere force-pushed the feature/CCM-13475_send_print_events branch from 61703dc to d9a4b1a Compare January 13, 2026 13:33

simonlabarere requested a review from a team as a code owner January 13, 2026 13:33

simonlabarere force-pushed the feature/CCM-13475_send_print_events branch 2 times, most recently from 16dabad to d9a4b1a Compare January 13, 2026 13:57

simonlabarere added 7 commits January 13, 2026 14:06

CCM-13475: Github token fix attempt

883f871

CCM-13475: Send print events

f2e18ae

CCM-13475: Send print events

cd9ef30

CCM-13475: Send print events

874098a

Merge branch 'main' into feature/CCM-13475_send_print_events

a1ce01c

CCM-13475: Send print events

d3a28ec

CCM-14347: Send Print config

cbe7ee4

nhsd-angel-pastor reviewed Jan 15, 2026

View reviewed changes

infrastructure/terraform/components/dl/cloudwatch_event_rule_letter_prepared.tf Show resolved Hide resolved

nhsd-angel-pastor reviewed Jan 15, 2026

View reviewed changes

lambdas/print-sender-lambda/src/app/print-sender.ts Show resolved Hide resolved

simonlabarere and others added 9 commits January 15, 2026 13:18

CCM-14347: Send Print config

8533768

CCM-14347: Send Print config

e15f07c

CCM-14347: Send Print config

8f90c56

CCM-14347: Send Print config

1e6d3bf

CCM-14347: Send Print config

7658aa1

CCM-14347: Send Print config

fd24d89

CCM-14347: Send Print config

0d1807e

CCM-14347: Send Print config

1c3bbee

Merge branch 'main' into feature/CCM-13475_send_print_events

4ba840b

lapenna-bjss force-pushed the feature/CCM-13475_send_print_events branch from a35e9f1 to 4ba840b Compare January 28, 2026 08:58

CCM-13475: Remove package-lock.json file

abce4d7

lapenna-bjss added 2 commits January 28, 2026 11:44

CCM-13475: Test

39a0605

CCM-13475: add input transformation

9fdee7a

nhsd-angel-pastor reviewed Jan 29, 2026

View reviewed changes

infrastructure/terraform/components/dl/modules_eventpub.tf Outdated Show resolved Hide resolved

nhsd-angel-pastor reviewed Jan 29, 2026

View reviewed changes

lambdas/print-sender-lambda/src/app/print-sender.ts Show resolved Hide resolved

lapenna-bjss added 3 commits January 29, 2026 16:00

CCM-13475: pin @nhsdigital/nhs-notify-event-schemas-supplier-api to 1…

48d8a4c

….0.6

CCM-13475: add campaignId to letter prepared events

47adec6

CCM-13475: fix linter error

266f4e3

nhsd-angel-pastor reviewed Jan 30, 2026

View reviewed changes

tests/playwright/digital-letters-component-tests/print-sender.component.spec.ts Show resolved Hide resolved

nhsd-angel-pastor reviewed Jan 30, 2026

View reviewed changes

gareth-allan self-assigned this Jan 30, 2026

gareth-allan reviewed Jan 30, 2026

View reviewed changes

lapenna-bjss added 5 commits February 2, 2026 10:21

CCM-13475: address comments

afa5e89

Merge branch 'main' into feature/CCM-13475_send_print_events

68c168d

CCM-13475: resolve fast-xml-parser security vulnerability

7c876f9

CCM-13475: Add eslint-disable sonarjs/hardcoded-secret-signatures in …

c161303

…validate-private-key.test.ts

CCM-13475: Add max_receive_count to print-sender queue

3aa0779

nhsd-angel-pastor previously approved these changes Feb 2, 2026

View reviewed changes

CCM-13475: Revert package-lock.json changes in docs/

6a07f96

lapenna-bjss dismissed nhsd-angel-pastor’s stale review via 6a07f96 February 2, 2026 15:45

gareth-allan approved these changes Feb 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CCM-13475: Send print events#179

CCM-13475: Send print events#179
simonlabarere wants to merge 31 commits intomainfrom
feature/CCM-13475_send_print_events

simonlabarere commented Jan 13, 2026 •

edited by lapenna-bjss

Loading

Uh oh!

Uh oh!

nhsd-angel-pastor Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nhsd-angel-pastor Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gareth-allan left a comment

Uh oh!

gareth-allan Feb 2, 2026

Uh oh!

gareth-allan Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

simonlabarere commented Jan 13, 2026 • edited by lapenna-bjss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test evidence

Print Sender logs

Event Bus logs

Type of changes

Checklist

Sensitive Information Declaration

Uh oh!

Uh oh!

nhsd-angel-pastor Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nhsd-angel-pastor Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gareth-allan left a comment

Choose a reason for hiding this comment

Uh oh!

gareth-allan Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

gareth-allan Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

simonlabarere commented Jan 13, 2026 •

edited by lapenna-bjss

Loading