CCM-13278: Confirm that we have received a file from a Trust#171
Closed
gareth-allan wants to merge 21 commits intomainfrom
Closed
CCM-13278: Confirm that we have received a file from a Trust#171gareth-allan wants to merge 21 commits intomainfrom
gareth-allan wants to merge 21 commits intomainfrom
Conversation
f65e817 to
5e39535
Compare
4ec46d3 to
9bc8e6c
Compare
18fb2ca to
99a2f39
Compare
99a2f39 to
b1a6b60
Compare
Ian-Hodges
reviewed
Jan 16, 2026
infrastructure/terraform/components/dl/module_lambda_mesh_acknowledge.tf
Outdated
Show resolved
Hide resolved
Ian-Hodges
reviewed
Jan 16, 2026
infrastructure/terraform/components/dl/module_sqs_mesh_acknowledge.tf
Outdated
Show resolved
Hide resolved
gareth-allan
commented
Jan 19, 2026
Contributor
Author
gareth-allan
left a comment
There was a problem hiding this comment.
Just a couple of minor post-merge comments.
utils/sender-management/sender_management/__tests__/test_sender_lookup.py
Show resolved
Hide resolved
simonlabarere
previously approved these changes
Jan 21, 2026
sidnhs
previously approved these changes
Jan 21, 2026
Ian-Hodges
reviewed
Jan 21, 2026
Contributor
There was a problem hiding this comment.
I'm surprised the python event publisher is doing anything with mesh?
Contributor
There was a problem hiding this comment.
It is now moved to a utility package for Python projects.
11 tasks
Contributor
|
See #186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the MESH Acknowledger component.
meshMessageIdfield to theMESHInboxMessageDownloadedeventsrc/python-schema-generatorsender_lookup.pyfile added to the mesh-poll lambda in CCM-12616 mesh poll retrieve #104 to thesender-managementpackage that currently contains the TypeScript sender management librarydigital-letters-eventspackage, where we have both TS and Python packages in a single directorypackage_python_lambda.shscript toutilsContext
Notify is documented as providing acknowledgement messages in response to MESH messages received. This provides confirmation that a request was successfully received. Since the integrator response is documented publicly, users of Digital Letters are likely to expect it, given they will be unaware that we’re operating within a bounded context that doesn’t include all of Core’s functionality, so we should implement the same functionality in Digital Letters.
Validation
To check that publishing directly to the DLQ works, I manually updated the configuration of the mesh-acknowledge lambda to set an incorrect event bridge ARN and event bridge DLQ URL and then used the Lambda's "test" function to send a valid message downloaded event. This resulted in the event publishing and DLQ-ing failing, and so the function pushed the record directly to the DLQ:



Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.