Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ on: [push]
jobs:
test:
strategy:
fail-fast: false
matrix:
ruby-version:
- '3.1'
- '3.2'
- '3.3'
- '3.4'
gemfile:
- gemfiles/Gemfile.rails70
- gemfiles/Gemfile.rails71
- gemfiles/Gemfile.rails72
- gemfiles/Gemfile.rails80
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [Unreleased]
* no unreleased changes
### Fixed
* Support Ruby 3.4. Drop support for Rails 7.0, Ruby 3.1

## 0.4.3 / 2024-11-19
### Added
Expand Down
13 changes: 0 additions & 13 deletions gemfiles/Gemfile.rails70

This file was deleted.

7 changes: 6 additions & 1 deletion lib/ndr_browser_timings/recorders/logger.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ module Recorders
# Allows timing information to be recorded via the application log.
class Logger
def call(timing)
Rails.logger.info "NdrBrowserTimings #{timing.tags} #{timing.timeline}"
# Ensure consistent log format, even though Hash#to_s changed in ruby 3.4
format_hash = lambda do |hash|
format('{%<entries>s}',
entries: hash.collect { |k, v| "#{k.inspect}=>#{v.inspect}" }.join(', '))
end
Rails.logger.info "NdrBrowserTimings #{format_hash.call(timing.tags)} #{format_hash.call(timing.timeline)}"
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions ndr_browser_timings.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ Gem::Specification.new do |spec|
spec.files = `git ls-files -z`.split("\x0").
select { |f| gem_files.include?(f.split('/')[0]) }

spec.add_dependency 'rails', '>= 7.0', '< 8.1'
spec.add_dependency 'rails', '>= 7.1', '< 8.1'

spec.required_ruby_version = '>= 3.1.0'
spec.required_ruby_version = '>= 3.2.0'

spec.add_development_dependency 'mocha'
spec.add_development_dependency 'ndr_dev_support', '>= 6.0'
Expand Down