[PRMP-1326] Add Review Journey Remove All page #1024

lillie-dae · 2026-01-28T11:57:43Z

Overview

Jira ticket: PRMP-1326

Description

Context

review_jounrey_remove_all.webm

Checklist

Tasks for all changes:

1. I have linked this PR to its Jira ticket.
2. ~~I have run git pre-commits.~~ (WIP)
3. I have added and/or updated relevant tests.
4. I have updated relevant documentation.
5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:
- 6a. Deploy - Sandbox - workflow run - TBC
- 6b. SANDBOX Full- Deploy feature branch to sandbox - workflow run - TBC

Additional tasks for UI changes (delete if not applicable):

1. I have run the UI Smoke Tests against the deployed sandbox and witnessed it passing:
- 1a. SANDBOX - UI Smoke Test - workflow run - TBC
2. I have added evidence (to this PR) e.g. screenshots/gifs of all visual changes.

steph-torres-nhs · 2026-01-30T11:44:27Z

...ts/blocks/_admin/reviewDetailsDocumentRemoveAllStage/ReviewDetailsDocumentRemoveAllStage.tsx

+
+    return (
+        <>
+            <BackLink onClick={handleGoBack} data-testid="back-button">


Back button component does this by default, should we use it here?

steph-torres-nhs · 2026-01-30T11:45:12Z

...ocks/_admin/reviewDetailsDocumentRemoveAllStage/ReviewDetailsDocumentRemoveAllStage.test.tsx

+        it('renders the back link with correct text', () => {
+            render(
+                <ReviewDetailsDocumentRemoveAllStage
+                    reviewData={mockReviewData}
+                    documents={mockDocuments}
+                    setDocuments={mockSetDocuments}
+                />,
+            );
+
+            expect(screen.getByTestId('back-button')).toBeInTheDocument();
+            expect(screen.getByText('Go back')).toBeInTheDocument();
+        });
+
+        it('renders DocumentUploadRemoveFilesStage component', () => {
+            render(
+                <ReviewDetailsDocumentRemoveAllStage
+                    reviewData={mockReviewData}
+                    documents={mockDocuments}
+                    setDocuments={mockSetDocuments}
+                />,
+            );
+
+            expect(
+                screen.getByRole('heading', {
+                    name: 'Are you sure you want to remove all selected files?',
+                }),
+            ).toBeInTheDocument();
+        });
+
+        it('renders remove files button', () => {
+            render(
+                <ReviewDetailsDocumentRemoveAllStage
+                    reviewData={mockReviewData}
+                    documents={mockDocuments}
+                    setDocuments={mockSetDocuments}
+                />,
+            );
+
+            expect(
+                screen.getByRole('button', { name: 'Yes, remove all files' }),
+            ).toBeInTheDocument();
+        });
+
+        it('renders cancel button', () => {
+            render(
+                <ReviewDetailsDocumentRemoveAllStage
+                    reviewData={mockReviewData}
+                    documents={mockDocuments}
+                    setDocuments={mockSetDocuments}
+                />,
+            );
+
+            expect(screen.getByRole('button', { name: 'Cancel' })).toBeInTheDocument();
+        });


feels like this could be one test?

adamwhitingnhs · 2026-01-30T11:46:31Z

...ocks/_admin/reviewDetailsDocumentRemoveAllStage/ReviewDetailsDocumentRemoveAllStage.test.tsx

+                    documents={mockDocuments}
+                    setDocuments={mockSetDocuments}
+                />,
+            );


Could you use the "renderApp" pattern that we use in other tests please

adamwhitingnhs · 2026-01-30T11:52:18Z

...nts/blocks/_admin/reviewDetailsDocumentSelectStage/ReviewDetailsDocumentSelectStage.test.tsx

-            </div>
-        </div>
-    )),
+    default: vi.fn(


Can we do these tests without mocking this component? Given that these components are a wrapper around the upload ones, we should probably test that it works when using the actual base component.

steph-torres-nhs · 2026-01-30T12:02:36Z

app/src/components/blocks/_documentUpload/documentSelectStage/DocumentSelectStage.test.tsx

+            expect(dashCell).toBeInTheDocument();
+        });
+
+        it('allows removing additional documents but not review documents', async () => {


do we want to check that a button for trying to remove review doc doesn't exist?

steph-torres-nhs · 2026-01-30T12:03:55Z

...locks/_documentUpload/documentUploadRemoveFilesStage/DocumentUploadRemoveFilesStage.test.tsx

+        it('renders the confirmation page with correct title', async () => {
            render(
                <DocumentUploadRemoveFilesStage
                    documents={documents}
-                    setDocuments={() => {}}
+                    setDocuments={mockSetDocuments}
                    documentType={DOCUMENT_TYPE.LLOYD_GEORGE}
                />,
            );

-            await waitFor(async () => {
+            await waitFor(() => {
                expect(
                    screen.getByText('Are you sure you want to remove all selected files?'),
                ).toBeInTheDocument();
            });
        });
+
+        it('renders remove files button', () => {
+            render(
+                <DocumentUploadRemoveFilesStage
+                    documents={documents}
+                    setDocuments={mockSetDocuments}
+                    documentType={DOCUMENT_TYPE.LLOYD_GEORGE}
+                />,
+            );
+
+            expect(screen.getByTestId('remove-files-button')).toBeInTheDocument();
+            expect(screen.getByText('Yes, remove all files')).toBeInTheDocument();
+        });
+
+        it('renders cancel button', () => {
+            render(
+                <DocumentUploadRemoveFilesStage
+                    documents={documents}
+                    setDocuments={mockSetDocuments}
+                    documentType={DOCUMENT_TYPE.LLOYD_GEORGE}
+                />,
+            );
+
+            expect(screen.getByText('Cancel')).toBeInTheDocument();
+        });
+    });


can this be one test?

github-actions · 2026-01-30T16:09:33Z

Code security issues found

View full details here.

sonarqubecloud · 2026-01-30T16:12:50Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
97.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lillie-dae added 3 commits January 28, 2026 11:53

[PRMP-1326] Add Review Journey Remove All page

0db2bfc

minor fixes

ff1972d

removed some unneeded comments

104101b

lillie-dae marked this pull request as ready for review January 28, 2026 14:05

lillie-dae requested review from a team as code owners January 28, 2026 14:05

lillie-dae requested a review from AndyFlintAnswerDigital January 28, 2026 14:05

kamenbachvarov-nhs approved these changes Jan 28, 2026

View reviewed changes

adamwhitingnhs approved these changes Jan 29, 2026

View reviewed changes

steph-torres-nhs reviewed Jan 30, 2026

View reviewed changes

adamwhitingnhs reviewed Jan 30, 2026

View reviewed changes

steph-torres-nhs reviewed Jan 30, 2026

View reviewed changes

SWhyteAnswer temporarily deployed to development January 30, 2026 13:06 — with GitHub Actions Inactive

SWhyteAnswer temporarily deployed to development January 30, 2026 13:07 — with GitHub Actions Inactive

SWhyteAnswer temporarily deployed to development January 30, 2026 13:09 — with GitHub Actions Inactive

SWhyteAnswer temporarily deployed to development January 30, 2026 13:11 — with GitHub Actions Inactive

SWhyteAnswer temporarily deployed to development January 30, 2026 13:13 — with GitHub Actions Inactive

Merge branch 'main' into PRMP-1326

f89755f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PRMP-1326] Add Review Journey Remove All page #1024

[PRMP-1326] Add Review Journey Remove All page #1024

Uh oh!

lillie-dae commented Jan 28, 2026 •

edited

Loading

Uh oh!

steph-torres-nhs Jan 30, 2026

Uh oh!

steph-torres-nhs Jan 30, 2026

Uh oh!

adamwhitingnhs Jan 30, 2026

Uh oh!

adamwhitingnhs Jan 30, 2026

Uh oh!

steph-torres-nhs Jan 30, 2026

Uh oh!

steph-torres-nhs Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

sonarqubecloud bot commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[PRMP-1326] Add Review Journey Remove All page #1024

Are you sure you want to change the base?

[PRMP-1326] Add Review Journey Remove All page #1024

Uh oh!

Conversation

lillie-dae commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Description

Context

Checklist

Uh oh!

steph-torres-nhs Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

steph-torres-nhs Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

adamwhitingnhs Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

adamwhitingnhs Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

steph-torres-nhs Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

steph-torres-nhs Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 30, 2026

Code security issues found

Uh oh!

sonarqubecloud bot commented Jan 30, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lillie-dae commented Jan 28, 2026 •

edited

Loading