MNS-2023: add notify test result event#434
Merged
acarriedev merged 4 commits intomasterfrom Mar 13, 2026
Merged
Conversation
johnwilliams57-nhs
requested changes
Mar 13, 2026
Contributor
johnwilliams57-nhs
left a comment
johnwilliams57-nhs
left a comment
There was a problem hiding this comment.
looks good. just missing a couple of quotes
| status: "requested" | ||
| end: "2022-04-05T17:31:00.000Z" | ||
| reason: "Business process A" | ||
| criteria: "eventType=pathology-laboratory-reporting-test-result-stored-1 AND requestingOrganisationODS_manufacturer_org=A12345" |
Contributor
There was a problem hiding this comment.
i think there should be single quotes around the A12345
ideally there should be single quotes around the event type too, but we handle no quotes there
johnwilliams57-nhs
approved these changes
Mar 13, 2026
Contributor
johnwilliams57-nhs
left a comment
johnwilliams57-nhs
left a comment
There was a problem hiding this comment.
looks good. thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.