PPHA-602: Updated backlinks to go to check-your-answers when updating responses by stephhou · Pull Request #421 · NHSDigital/lung_cancer_screening

stephhou · 2026-03-30T09:54:32Z

What is the change?

Changed the order of responses on check-your-answers page to match page order.
Updated question base view to create a boolean based on the value of Change parameter for both GET and POST requests
Changed backlinks on all pages that should return to check-your-answers page, when editing responses.

Why are we making this change?

To ensure a good user experience by making the backlinks behave in an intuitive way when editing responses to questions.

Signed-off-by: Steph Housden <167300771+stephhou@users.noreply.github.com>

Copilot

Pull request overview

This PR improves the “change answers” journey by ensuring question pages can detect when a user is editing answers from the check-your-answers page, and adjusts back-link behavior accordingly.

Changes:

Add/standardize “change mode” detection (is_changing_responses) and update back-link destinations to return to questions:responses when editing.
Reorder “Sex at birth” and “Gender identity” items on the check-your-answers presenter to match question flow.
Add unit tests covering new back-link behavior across multiple question pages.

Reviewed changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
lung_cancer_screening/questions/views/question_base_view.py	Renames/expands change-mode detection and uses it for success redirects.
lung_cancer_screening/questions/views/weight.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/height.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/gender.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/sex_at_birth.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/ethnicity.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/education.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/respiratory_conditions.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/asbestos_exposure.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/cancer_diagnosis.py	Back-link now returns to responses when changing; otherwise previous question.
lung_cancer_screening/questions/views/family_history_lung_cancer.py	Uses `is_changing_responses` and adds change-mode back-link.
lung_cancer_screening/questions/views/relatives_age_when_diagnosed.py	Adds change-mode back-link while keeping prerequisite redirect logic.
lung_cancer_screening/questions/views/have_you_ever_smoked.py	Adds change-mode back-link while preserving ineligible exit behavior.
lung_cancer_screening/questions/views/date_of_birth.py	Adds change-mode back-link while preserving age-range exit behavior.
lung_cancer_screening/questions/views/age_when_started_smoking.py	Uses `is_changing_responses` and adds change-mode back-link.
lung_cancer_screening/questions/views/periods_when_you_stopped_smoking.py	Adds change-mode back-link.
lung_cancer_screening/questions/views/types_tobacco_smoking.py	Computes back-link via helper; introduces local change-mode detection.
lung_cancer_screening/questions/views/smoking_current.py	Back-link returns to responses when changing; preserves change query param when navigating back to types.
lung_cancer_screening/questions/views/smoking_change.py	Renames change-mode helper and wires it into success/query-param logic.
lung_cancer_screening/questions/views/smoked_total_years.py	Switches to `is_changing_responses` to control redirect flow.
lung_cancer_screening/questions/presenters/response_set_presenter.py	Reorders “Sex at birth” item to match the actual question order.
lung_cancer_screening/questions/jinja2/weight.jinja	Removes hardcoded back-link block so layout-driven back-link can be used.
lung_cancer_screening/questions/jinja2/height.jinja	Removes hardcoded back-link block so layout-driven back-link can be used.
lung_cancer_screening/questions/tests/unit/views/test_weight.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_height.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_gender.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_sex_at_birth.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_ethnicity.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_education.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_respiratory_conditions.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_asbestos_exposure.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_cancer_diagnosis.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_family_history_lung_cancer.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_relatives_age_when_diagnosed.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_have_you_ever_smoked.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_date_of_birth.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_age_when_started_smoking.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_periods_when_you_stopped_smoking.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_types_tobacco_smoking.py	Adds back-link tests for change vs non-change mode.
lung_cancer_screening/questions/tests/unit/views/test_smoking_current.py	Adds back-link test for change mode in smoking_current.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lung_cancer_screening/questions/tests/unit/views/test_periods_when_you_stopped_smoking.py

Copilot · 2026-03-30T13:52:04Z

lung_cancer_screening/questions/views/question_base_view.py

+    def is_changing_responses(self):
+        return bool(self.request.GET.get("change")) or bool(self.request.POST.get("change"))


is_changing_responses() treats any non-empty change value as true, but templates only persist the hidden POST field when change == "True". This can lead to GET behaving like “change mode” while the subsequent POST is not. Consider explicitly checking for the expected value (e.g., GET/POST change equals "True") to keep behavior consistent.

Copilot · 2026-03-30T13:52:05Z

lung_cancer_screening/questions/views/types_tobacco_smoking.py

        return reverse(
            "questions:smoking_current",
            kwargs={
                "tobacco_type": next_tobacco_smoking_history.url_type()
            },


When arriving from the check-your-answers “Change” link, this view receives ?change=True, but the redirect URL built here drops that flag. That means subsequent smoking pages won't know they're in “change mode”, and their back links won’t return to the responses page. Preserve the change query param in this redirect (or redirect straight back to responses when changing).

Copilot · 2026-03-30T13:52:05Z

lung_cancer_screening/questions/views/types_tobacco_smoking.py

+    def is_changing_responses(self):
+        return bool(self.request.GET.get("change")) or bool(self.request.POST.get("change"))
+


is_changing_responses() uses bool(request.GET/POST.get("change")), which will treat any non-empty value (including unexpected ones) as “changing”. Given templates only set the hidden POST field when change == "True", consider checking explicitly for the expected value to avoid inconsistent GET vs POST behavior.

Copilot · 2026-03-30T13:52:05Z

lung_cancer_screening/questions/tests/unit/views/test_sex_at_birth.py

+    def test_back_link_url_points_to_agree_terms_of_use_if_change_query_param_is_not_true(self):
+        ResponseSetFactory.create(user=self.user, eligible=True)
+        response = self.client.get(
+            reverse("questions:sex_at_birth")
+        )
+
+        self.assertEqual(response.context_data["back_link_url"], reverse("questions:gender"))


The test name says the back link should point to agree_terms_of_use, but the assertion expects the gender URL. Rename the test (or adjust the expected URL) so the test description matches the behavior being verified.

Copilot · 2026-03-30T13:52:05Z

lung_cancer_screening/questions/tests/unit/views/test_types_tobacco_smoking.py

+            ResponseSetFactory.create(user=self.user, eligible=True)
+
+            response = self.client.get(
+                reverse("questions:types_tobacco_smoking")
+            )
+
+            self.assertEqual(
+                response.context_data["back_link_url"],
+                reverse("questions:periods_when_you_stopped_smoking")
+            )


The new test method has its body over-indented, which will raise an IndentationError and prevent the test module from importing. Align the method body indentation with the other test methods in this class.

Suggested change

ResponseSetFactory.create(user=self.user, eligible=True)

response = self.client.get(

reverse("questions:types_tobacco_smoking")

)

self.assertEqual(

response.context_data["back_link_url"],

reverse("questions:periods_when_you_stopped_smoking")

)

ResponseSetFactory.create(user=self.user, eligible=True)

response = self.client.get(

reverse("questions:types_tobacco_smoking")

)

self.assertEqual(

response.context_data["back_link_url"],

reverse("questions:periods_when_you_stopped_smoking")

)

lung_cancer_screening/questions/tests/unit/views/test_family_history_lung_cancer.py

…when_you_stopped_smoking.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Steph Housden <167300771+stephhou@users.noreply.github.com>

sonarqubecloud · 2026-03-30T13:59:38Z

Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

stephhou and others added 13 commits March 30, 2026 10:37

fix: updated order of responses to match the order of questions

179602c

fix: updated backlinks for height and weight

6659c65

fix: updated backlink for date of birth

5802945

fix: updated question base to take change value from GET and POST

cd04aba

fix: updated backlinks for smoking history

3fc13d8

fix: removed unused backlink

78c79ab

fix: updated function name

9ed8c01

fix: updated backlink for gender page

2d50da1

fix: moved tests to correct class

7af7566

fix: updated backlinks for age started smoking

6b5051b

fix: updated asbestos exposure backlink

593a932

Merge branch 'main' into PPHA-602-Update-conditional-backlinks

46d28d6

Merge branch 'main' into PPHA-602-Update-conditional-backlinks

1cb295e

Signed-off-by: Steph Housden <167300771+stephhou@users.noreply.github.com>

stephhou changed the title ~~PPHA-602: Updated backlinks to go to check-you-answers when updating responses~~ PPHA-602: Updated backlinks to go to check-your-answers when updating responses Mar 30, 2026

stephhou and others added 5 commits March 30, 2026 13:50

Merge branch 'main' into PPHA-602-Update-conditional-backlinks

c9e350e

fix: updated backlinks

a3edbc4

fix: update tests to be more specific

659ed73

Merge branch 'main' into PPHA-602-Update-conditional-backlinks

1978b48

Merge branch 'main' into PPHA-602-Update-conditional-backlinks

9630c1b

stephhou marked this pull request as ready for review March 30, 2026 13:43

Copilot AI review requested due to automatic review settings March 30, 2026 13:43

Copilot started reviewing on behalf of stephhou March 30, 2026 13:44 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Update lung_cancer_screening/questions/tests/unit/views/test_periods_…

5ca462a

…when_you_stopped_smoking.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Steph Housden <167300771+stephhou@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPHA-602: Updated backlinks to go to check-your-answers when updating responses#421

PPHA-602: Updated backlinks to go to check-your-answers when updating responses#421
stephhou wants to merge 19 commits intomainfrom
PPHA-602-Update-conditional-backlinks

stephhou commented Mar 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		def is_changing_responses(self):
		return bool(self.request.GET.get("change")) or bool(self.request.POST.get("change"))

Conversation

stephhou commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the change?

Why are we making this change?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 30, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stephhou commented Mar 30, 2026 •

edited

Loading