PPHA-602: Fix smoking change journey redirects#413
Open
Themitchell wants to merge 4 commits intomainfrom
Open
Conversation
Themitchell
force-pushed
the
PPHA-602-fix-smoking-change-journey-redirects
branch
from
1199acd to
f1d9655
Compare
When coming to the end of a journey for a particular smoking history type make sure to redirect to responses if the participant is coming from the chekc your answeres page
Themitchell
force-pushed
the
PPHA-602-fix-smoking-change-journey-redirects
branch
from
0a61909 to
9530a76
Compare
Themitchell
force-pushed
the
PPHA-602-fix-smoking-change-journey-redirects
branch
from
9530a76 to
2700444
Compare
|
jamiefalcus
reviewed
Mar 30, 2026
| self.assertRedirects(response, reverse("questions:responses")) | ||
|
|
||
|
|
||
| def test_redirects_to_responses_if_change_true_and_no_change_is_selected_and_another_type_exists(self): |
Contributor
There was a problem hiding this comment.
duplicate of previous test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
When changing responses for a given smoking journey, ensure that the participant is redirects back to
/check-your-answersrather than re doing the entire smoking journeyWhy are we making this change?
To ensure users can quickly navigate specific smoking journeys without having to resubmit responses everywhere