Draft
Conversation
jamiefalcus
reviewed
Feb 2, 2026
| suffix=self._type_suffix(), | ||
| required=True, | ||
| error_messages={ | ||
| "required": self._type_required_error_message() |
Contributor
There was a problem hiding this comment.
At least 1 error here? (and test)
| return self.instance.tobacco_smoking_history.human_type().lower() | ||
|
|
||
| def _type_label(self): | ||
| return f"Roughly how many {self.type_string()} do you smoke in a normal day?" |
Contributor
There was a problem hiding this comment.
Shouldn't this have the answer from frequency rather than hard coded day?
Themitchell
force-pushed
the
PPHA-534-normal-amount-smoked
branch
from
7f92e2c to
5a4c015
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Add pages for normal amount smoked per
Why are we making this change?
In order to allow users to give details about their smoking history ready for calculating their risk of lung cancer
TODO:
Screenshots