VED-240 Handle-PDS-Rate-Limit #1174
Open
+425
−262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-240 |
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
…ital/immunisation-fhir-api into VED-240-handle-rate-limit
…ital/immunisation-fhir-api into VED-240-handle-rate-limit
…ital/immunisation-fhir-api into VED-240-handle-rate-limit
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
|
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JamesW1-NHS
reviewed
Jan 30, 2026
|
|
||
|
|
||
| def request_with_retry_backoff( | ||
| url: str, headers: dict, *, timeout: int = 5, max_retries: int = 2, backoff_seconds: float = 0.5 |
Contributor
There was a problem hiding this comment.
Should we put these default values somewhere as constants?
| # Ensure retryable codes include 429/5xx only (example) | ||
| with patch.object(Constants, "RETRYABLE_STATUS_CODES", {429, 500, 502, 503, 504}): | ||
| # Act | ||
| resp = request_with_retry_backoff("http://example.com", {}, max_retries=2, backoff_seconds=0.5) |
Contributor
There was a problem hiding this comment.
We're using the default values for max_retries and backoff_seconds each time we call request_with_retry_backoff() here - should we just leave them out?
| } | ||
| response = requests.get(f"{self.base_url}/{patient_id}", headers=request_headers, timeout=5) | ||
| response = request_with_retry_backoff( | ||
| f"{self.base_url}/{patient_id}", headers=request_headers, timeout=5, max_retries=2, backoff_seconds=0.5 |
Contributor
There was a problem hiding this comment.
We're using the default values for timeout, max_retries and backoff_seconds here - should we just leave them out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented improved HTTP error handling and retry logic for PDS client integration to support clearer failure diagnostics and resilience against transient downstream failures.
Also made the mns error handling function reusable and moved to shared, so it can be re-used for PDS
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.