Skip to content

Conversation

@dlzhry2nhs
Copy link
Collaborator

@dlzhry2nhs dlzhry2nhs commented Jan 29, 2026

Summary

  • Routine Change

Existing problem:
All pipelines generate and publish an allure report. This is not strictly needed, and given the use of Github Pages, we can run into a potential race condition.

Proposed solution:
As suggested by Fatima, on the regular dev PR and CI/CD pipelines, we only really need the test output from the console, and additionally could display the nicer XML BDD summary.
However, we should limit the allure report to only fire on manual dispatch. Usually there would only be one running at a time and this is mainly used by automation testers.

Changes:

  • separated out the jobs that run the tests and the one that creates the report
  • made the test report job depend on the tests run being completed - failed or succeeded
  • ensure that on pipeline CI/CD, PR we only publish the simple xml output, and when run manually we also include the Allure report

Testing:

Tested in the PR pipeline of this ticket:

Demonstrated that only the xml output is provided and Allure reports are skipped. You can navigate to the workflow summary to see the BDD report, although for most devs the standard Github runner output logging should suffice.
image

Tested using the manual pipeline twice with 2 different sets of tests:

Demonstrated that Allure reports were published. The latest report is always published to the Github Pages:
image

Reviews Required

  • Dev
  • Test

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1036

@sonarqubecloud
Copy link

@dlzhry2nhs dlzhry2nhs marked this pull request as ready for review January 30, 2026 12:24
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox January 30, 2026 12:29 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox January 30, 2026 12:30 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs enabled auto-merge (squash) January 30, 2026 12:53
@dlzhry2nhs dlzhry2nhs merged commit 0f37f45 into master Jan 30, 2026
17 checks passed
@dlzhry2nhs dlzhry2nhs deleted the feature/VED-1036-tidy-up-pipeline-test-reporting branch January 30, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants