VED-1040: Terraform Docker build improvements

[edhall-nhs]

Summary

• Routine Change
• 🤖 Operational or Infrastructure Change
• ⚠️ Potential issues that might be caused by this change

Main objectives of this ticket are:

• Allow rollback capability for lambda deployments via updating image tagging logic
• Only trigger builds if relevant files are changed (e.g. ignore README.md updates
• Potential change to ECR setup
• General terraform tidy up

Reviews Required

• Dev
• Test
• Tech Author
• Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
• I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

[github-actions]

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1040

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[edhall-nhs]

Closing this PR as the desired functionality is likely not possible with the current deployment strategy of building and pushing Docker images via terraform. Please see the accompanying ticket for more details.

I've created a separate PR for some general terraform tidy up which supersedes this one