VED-901: Update extended attributes destination.

[mfjarvis]

Summary

• Routine Change

Don't merge yet - this approach still needs testing on the DPS side.

• Update destination S3 bucket for extended attributes files to be the generic S3 submissions bucket in the DSPP Core account.
• Update KMS key to the key associated with the new destination.
• Update the prefix to the required value for these files to be processed as extended attributes files.
• Enable linting / formatting on commit for tfvars files.

Reviews Required

• Dev
• Test
• Tech Author
• Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
• I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

[github-actions]

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-901

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud