Skip to content

Conversation

@ellie-bound1-NHSD
Copy link
Contributor

@ellie-bound1-NHSD ellie-bound1-NHSD commented Jan 29, 2026

…st of URLs

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6139


📄 Description/Summary of Changes

  • Up Rate Limit
  • Update App Imports
  • Check for Allowed List of URLs in application layer
  • Set base url per supplier for each environment which is passed in an environment variable

🧪 Developer Testing Carried Out

  • Unit tests added/updated
  • End to end tests added/updated

✅ Developer Checklist

  • I have set the PR title to follow the format: NPA-XXXX: <short-description>
  • My branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • My commit messages follow the template: NPA-XXXX: <short-description>
  • I have updated the documentation accordingly
  • I have set assignees and added appropriate labels

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ellie-bound1-NHSD ellie-bound1-NHSD self-assigned this Jan 29, 2026
@ellie-bound1-NHSD ellie-bound1-NHSD added documentation Improvements or additions to documentation validation labels Jan 29, 2026
@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the task/NPA-6139/enforce-allow-list-of-urls branch from 260c623 to 1803a14 Compare January 30, 2026 08:55
@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the task/NPA-6139/enforce-allow-list-of-urls branch from 1803a14 to c6f079d Compare January 30, 2026 09:02
@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the task/NPA-6139/enforce-allow-list-of-urls branch from 80fc227 to bc585bb Compare January 30, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant