Skip to content

[PRM-678] Remove public-read acl from gatsby-config so files can be added to S3 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samfallowfield wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[PRM-678] Remove public-read acl from gatsby-config so files can be added to S3 #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37506f4
[PRM-678] - remove public acl from gatsby-config
samfallowfield Jan 30, 2026
72e7bf7
Removed git_ref from inputs for infrastructure workflow as already ha…
oliverbeumkes-nhs Jan 30, 2026
62680b9
Removed git_ref from inputs for infrastructure workflow as already ha…
oliverbeumkes-nhs Jan 30, 2026
aee37da
updated is_deployment to true if deploying from a tag
oliverbeumkes-nhs Jan 30, 2026
4e3ab33
Flipped the startswith around
oliverbeumkes-nhs Jan 30, 2026
0625cee
Let's try "bucket-owner-full-control" instead
chrisbloe Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/dashboard-build-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,11 @@ jobs:
uses: NHSDigital/gp2gp-reporting-infrastructure/.github/workflows/deploy-stack.yml@v3
with:
environment: ${{ inputs.environment }}
is_deployment: ${{ github.ref == 'refs/heads/main' }}
is_deployment: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') }}
terraform_stack: gp2gp_dashboard
image_tag: gp2gp-dashboard
hyphenated_alias: gp2gp-dashboard
build_lambda: true
git_ref: ${{ github.ref }}
secrets: inherit

redeploy_gp2gp_infrastructure_step_functions:
Expand All @@ -106,8 +105,7 @@ jobs:
uses: NHSDigital/gp2gp-reporting-infrastructure/.github/workflows/deploy-stack.yml@v3
with:
environment: ${{ inputs.environment }}
is_deployment: ${{ github.ref == 'refs/heads/main' }}
is_deployment: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') }}
terraform_stack: step_function
hyphenated_alias: step-function
git_ref: ${{ github.ref }}
secrets: inherit
2 changes: 1 addition & 1 deletion dashboard/gatsby-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = {
bucketName: `${process.env.DEPLOYMENT_BUCKET}`,
region: "eu-west-2",
parallelLimit: 1000,
acl: "public-read",
acl: "bucket-owner-full-control",
},
},
{
Expand Down
Loading