Skip to content

Update: [AEA-6321] - Retrieve FHIR Package#4466

Merged
anthony-nhs merged 14 commits intomasterfrom
AEA-6321-Retrieve-FHIR-Package
Mar 26, 2026
Merged

Update: [AEA-6321] - Retrieve FHIR Package#4466
anthony-nhs merged 14 commits intomasterfrom
AEA-6321-Retrieve-FHIR-Package

Conversation

@kieran-wilkinson-4
Copy link
Copy Markdown
Contributor

Summary

Initialise FHIR Package Generation package and download FHIR package

Details

  • Creates new package called "fire-schema-generation"
  • Configures npm, ts, and jest
  • Script to download and pull json schema from FHIR package via Simplify
  • Add unit tests

@github-actions
Copy link
Copy Markdown
Contributor

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-6321

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new packages/fhir-schema-generation workspace intended to download a FHIR package from the Simplifier registry, extract it locally, and serve as the foundation for generating JSON schemas/OAS schema content from FHIR profile definitions.

Changes:

  • Adds a new Node/TypeScript workspace with Jest + ESLint configuration and initial download/extract implementation.
  • Adds unit tests for the package download/extract logic.
  • Integrates the new workspace into the monorepo tooling (workspaces, Makefile targets, Sonar coverage paths, pre-commit, docs, ignores).

Reviewed changes

Copilot reviewed 17 out of 20 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
sonar-project.properties Adds lcov path for the new workspace.
packages/fhir-schema-generation/tsconfig.json TypeScript build configuration for the new workspace.
packages/fhir-schema-generation/tests/fetch-fhir.test.ts Unit tests for querying/downloading/extracting the FHIR package.
packages/fhir-schema-generation/src/utils/fetch-fhir.ts Implements registry querying, tarball download, extraction, and manifest reading.
packages/fhir-schema-generation/src/models/fhir/fhir-package-metadata.ts Defines types for registry metadata response.
packages/fhir-schema-generation/src/index.ts Adds a runnable entrypoint that downloads a target package/version.
packages/fhir-schema-generation/package.json Declares the workspace package scripts and dependencies.
packages/fhir-schema-generation/jest.config.ts Jest configuration for TS/ESM tests and coverage output.
packages/fhir-schema-generation/eslint.config.mjs Extends root ESLint config with workspace-specific overrides.
packages/fhir-schema-generation/README.md Documents how to build/run/test the new workspace.
package.json Adds the new workspace to the monorepo workspaces list.
package-lock.json Updates lockfile to include the new workspace link and dependencies.
eslint.config.mjs Minor formatting fix in root ESLint config export.
README.md Adds the new workspace to the repo overview list.
Makefile Adds install/build/test/run/clean targets for the new workspace.
.vscode/launch.json Adds a debug configuration to run the new workspace with tsx.
.trivyignore.yaml Updates/extends vulnerability allowlist entries.
.pre-commit-config.yaml Adds a pre-commit hook to lint the new workspace.
.gitignore Ignores generated output (.output, build artifacts) for the new workspace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/fhir-schema-generation/package.json
Comment thread README.md Outdated
Comment thread Makefile Outdated
Comment thread packages/fhir-schema-generation/src/utils/fetch-fhir.ts Outdated
Comment thread packages/fhir-schema-generation/src/utils/fetch-fhir.ts Outdated
Comment thread packages/fhir-schema-generation/src/utils/fetch-fhir.ts Outdated
Comment thread packages/fhir-schema-generation/src/models/fhir/fhir-package-metadata.ts Outdated
Comment thread packages/fhir-schema-generation/package.json
Comment thread packages/fhir-schema-generation/package.json
Comment thread packages/fhir-schema-generation/tests/fetch-fhir.test.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 20 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/fhir-schema-generation/src/utils/fetch-fhir.ts
Comment thread Makefile
Comment thread packages/fhir-schema-generation/tests/fetch-fhir.test.ts
@sonarqubecloud
Copy link
Copy Markdown

@bencegadanyi1-nhs bencegadanyi1-nhs enabled auto-merge (squash) March 24, 2026 09:12
@anthony-nhs anthony-nhs disabled auto-merge March 26, 2026 10:38
@anthony-nhs anthony-nhs merged commit 54b5082 into master Mar 26, 2026
33 checks passed
@anthony-nhs anthony-nhs deleted the AEA-6321-Retrieve-FHIR-Package branch March 26, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants