Update: [AEA-6321] - Retrieve FHIR Package#4466
Conversation
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6321 |
08218b9 to
0a0a7a9
Compare
8a6e4f4 to
05f9ed0
Compare
05f9ed0 to
3239a4e
Compare
There was a problem hiding this comment.
Pull request overview
Introduces a new packages/fhir-schema-generation workspace intended to download a FHIR package from the Simplifier registry, extract it locally, and serve as the foundation for generating JSON schemas/OAS schema content from FHIR profile definitions.
Changes:
- Adds a new Node/TypeScript workspace with Jest + ESLint configuration and initial download/extract implementation.
- Adds unit tests for the package download/extract logic.
- Integrates the new workspace into the monorepo tooling (workspaces, Makefile targets, Sonar coverage paths, pre-commit, docs, ignores).
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| sonar-project.properties | Adds lcov path for the new workspace. |
| packages/fhir-schema-generation/tsconfig.json | TypeScript build configuration for the new workspace. |
| packages/fhir-schema-generation/tests/fetch-fhir.test.ts | Unit tests for querying/downloading/extracting the FHIR package. |
| packages/fhir-schema-generation/src/utils/fetch-fhir.ts | Implements registry querying, tarball download, extraction, and manifest reading. |
| packages/fhir-schema-generation/src/models/fhir/fhir-package-metadata.ts | Defines types for registry metadata response. |
| packages/fhir-schema-generation/src/index.ts | Adds a runnable entrypoint that downloads a target package/version. |
| packages/fhir-schema-generation/package.json | Declares the workspace package scripts and dependencies. |
| packages/fhir-schema-generation/jest.config.ts | Jest configuration for TS/ESM tests and coverage output. |
| packages/fhir-schema-generation/eslint.config.mjs | Extends root ESLint config with workspace-specific overrides. |
| packages/fhir-schema-generation/README.md | Documents how to build/run/test the new workspace. |
| package.json | Adds the new workspace to the monorepo workspaces list. |
| package-lock.json | Updates lockfile to include the new workspace link and dependencies. |
| eslint.config.mjs | Minor formatting fix in root ESLint config export. |
| README.md | Adds the new workspace to the repo overview list. |
| Makefile | Adds install/build/test/run/clean targets for the new workspace. |
| .vscode/launch.json | Adds a debug configuration to run the new workspace with tsx. |
| .trivyignore.yaml | Updates/extends vulnerability allowlist entries. |
| .pre-commit-config.yaml | Adds a pre-commit hook to lint the new workspace. |
| .gitignore | Ignores generated output (.output, build artifacts) for the new workspace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|



Summary
Initialise FHIR Package Generation package and download FHIR package
Details