Display DICOM thumbnails for an appointment#993
Conversation
| constructor($root) { | ||
| super($root) | ||
|
|
||
| const streamUrl = this.$root.getAttribute('data-stream-url') |
There was a problem hiding this comment.
If you can extend ConfigurableComponent instead?
There's a defaults and schema which automatically read data-* attributes, making this.config.streamUrl available for you automatically
Just needs a config @typedef and @augments tag too
There was a problem hiding this comment.
Thanks, good call!
There was a problem hiding this comment.
If you remove element and stick an informative identifier in you'll get a simpler "not found" error rather than something odd about HTMLElement 😆
Before
app-image-stream: data-stream-url attribute is not of type 'HTMLElement'
After
app-image-stream: Root element (
$root) attribute (data-stream-url) not found
- element: $root,
component: ImageStream,
- identifier: 'data-stream-url attribute'
+ identifier: `Root element (`$root`) attribute (\`data-stream-url\`)`
carlosmartinez
force-pushed
the
feat/display-thumbnails
branch
2 times, most recently
from
bf32f28 to
5c5c5f9
Compare
carlosmartinez
force-pushed
the
feat/display-thumbnails
branch
from
5c5c5f9 to
ab691bb
Compare
|
3 participants
Display DICOM thumbnails for an appointment
Description
When the radiographer takes scans using the modality, and these are saved to the gateway and sent to the Manage API, we want to display them – more-or-less in real time – in the "take images" page.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12206
Review notes
Since this is our first time doing "SSE type stuff" in Manage, it should be sufficiently sensible that we might consider following a similar pattern in future.
Also, the polling in
appointment_images_streammight not be to everyone's liking. We could use Django Channels or similar, but that would be a bit more infra. Happy to give this a try if you think it's a good idea.Review checklist