Skip to content

Add phone number formatting#988

Merged
cameronhargreaves1-nhs merged 1 commit intomainfrom
DTOSS-11889-phone-number-formatting
Feb 10, 2026
Merged

Add phone number formatting#988
cameronhargreaves1-nhs merged 1 commit intomainfrom
DTOSS-11889-phone-number-formatting

Conversation

@cameronhargreaves1-nhs
Copy link
Copy Markdown
Contributor

@cameronhargreaves1-nhs cameronhargreaves1-nhs commented Feb 4, 2026

Description

Add phone number formatting

Jira link

DTOSS-11889

Review notes

Review checklist

  • Check database queries are correctly scoped to current_provider

@cameronhargreaves1-nhs cameronhargreaves1-nhs force-pushed the DTOSS-11889-phone-number-formatting branch from 5c0fd9a to 232c8f7 Compare February 4, 2026 16:13
@cameronhargreaves1-nhs cameronhargreaves1-nhs marked this pull request as ready for review February 5, 2026 13:08
@cameronhargreaves1-nhs cameronhargreaves1-nhs changed the title Dtoss 11889 phone number formatting DTOSS-11889 Phone number formatting Feb 5, 2026
@malcolmbaig malcolmbaig changed the title DTOSS-11889 Phone number formatting Add phone number formatting Feb 9, 2026
Comment thread manage_breast_screening/core/utils/string_formatting.py
@malcolmbaig
Copy link
Copy Markdown
Contributor

Comment left suggesting the addition of a test case. Also commits need a rebase to exclude the commit related to update change links from this PR.

@cameronhargreaves1-nhs cameronhargreaves1-nhs force-pushed the DTOSS-11889-phone-number-formatting branch 3 times, most recently from fc4c2b9 to d59ad9b Compare February 9, 2026 21:40
- add library 'phonenumbers' to format phone numbers consistently
- update phone number formatting utility function to use the library
@cameronhargreaves1-nhs cameronhargreaves1-nhs force-pushed the DTOSS-11889-phone-number-formatting branch from d59ad9b to 6b09a09 Compare February 10, 2026 14:22
@sonarqubecloud
Copy link
Copy Markdown

@cameronhargreaves1-nhs cameronhargreaves1-nhs merged commit afd2b36 into main Feb 10, 2026
14 checks passed
@cameronhargreaves1-nhs cameronhargreaves1-nhs deleted the DTOSS-11889-phone-number-formatting branch February 10, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants