Merged
Conversation
MatMoore
reviewed
Feb 9, 2026
MatMoore
reviewed
Feb 9, 2026
MatMoore
requested changes
Feb 9, 2026
malcolmbaig
changed the title
This resolves Github security alerts for the workflows. Interpolating user input in the run block allows script injection. Moved to env as recommended in the alerts.
gpeng
force-pushed
the
DTOSS-12207-fix-script-injection-issues
branch
from
e688f99 to
0dcf2fd
Compare
Contributor
Author
|
Thanks @MatMoore. I've removed the linter script commit. |
|
MatMoore
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have 'a lot' of security alerts regarding string interpolation in run blocks in GitHub actions. I'm not sure they're particularly exploitable and I don't think we're running some of them (something else to review another time) but I've applied the suggested mitigation and added a linter rule to check for future 'violations'.
Also reordered the linting as I was getting prettier failures due to some local files and that was stopping the later linting from running.
If this gets approved/merged and I'll update the repo template.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12207