Feature/fix missing crc sheffield test scopes#186
Open
Conversation
This reverts commit f2d58c1.
shilpigoeldev
requested changes
Mar 20, 2026
test/lib/import/colorectal/providers/sheffield/sheffield_handler_colorectal_test.rb
Show resolved
Hide resolved
Contributor
|
@NImeson Can only see tests added for rules changes towards R210 panel and not R211 and R216, can those be added as well..thanks |
Collaborator
Author
shilpigoeldev
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Changes made to Sheffield CRC importer with new rules included.
New rules include:
https://nhsd-jira.digital.nhs.uk/browse/NDRS2-3697
Why?
A large number of recent records were being imported as having an unknown genetic testscope
Testing?
Tests have been added and QA counts carried out:
Unknown genetic test scope count is now limited to 3 records (these are in line with importer rules).
Final importer QA numbers equals raw counts
Anything Else?
No