Fix for regex unable to capture some exonic variants#143
Merged
shilpigoeldev merged 2 commits intodevelopfrom Feb 5, 2025
Merged
Fix for regex unable to capture some exonic variants#143shilpigoeldev merged 2 commits intodevelopfrom
shilpigoeldev merged 2 commits intodevelopfrom
Conversation
NImeson
reviewed
Feb 5, 2025
| ex(on)?s?\s?(?<exons>[0-9ACGT]+((to|and|-|\s)+[0-9ACGT]+)?)\s?(?<variant>del|dup|ins)?| | ||
| (?<exons>x(on)?s?\s?[0-9ACGT]+(to|and|-|\s)?x(on)?s?[0-9ACGT]+)(?<variant>del|dup|ins)| | ||
| x(?<exons>[0-9+-? ACGT]+)+(?<variant>del|dup|ins)| | ||
| ^(?<variant>del|dup|ins)\s?(?<exons>[0-9]+((to|and|-|\s)+[0-9ACGT]+)?) |
Collaborator
There was a problem hiding this comment.
Looks fine to me, i'm just wondering whether it is worth expanding to account for the potential of there being a ' ' before the del/dup when it is in the x1-x2.. / ex1-ex2... format? Currently it would only match the full variant(both if e.g. 'x14-x20del' rather than "x14-x20 del"?
Contributor
Author
Collaborator
There was a problem hiding this comment.
Great, all looks good to me then :)
NImeson
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Few of the exonic variants were not being captured correctly via Newcastle BRCA importer. This will resolve https://nhsd-jira.digital.nhs.uk/browse/NDRS2-2551
Why?
Regex was picking the second location of variant and not the whole range.
How?
Have updated the regex so that it can capture the range for such cases.
Testing?
Have updated the tests as well.
Anything Else ?
None