Bug/ndit 868 #32
Bug/ndit 868 #32
Conversation
…ssing a text file - applied for all reads via read_to_entity_type
|
| delim: str = ",", | ||
| quotechar: str = '"', | ||
| connection: Optional[DuckDBPyConnection] = None, | ||
| field_check: bool = False, |
There was a problem hiding this comment.
think if we are adding these attributes then we need to add them to the docstrings explaining to the user what they are. Not as obvious vs existing attrs like header, delim etc.
| expression_list = _split_multiexpr_string(expressions) | ||
| return expr_array_to_columns(expression_list) | ||
|
|
||
| def check_csv_header_expected( |
There was a problem hiding this comment.
move to base utils? Not specific to a backend
| self._logger.exception(exc) | ||
| sub_stats = None | ||
| report_uri = None | ||
| submission_status.processing_failed = True |
There was a problem hiding this comment.
build a submission status if there isn't a submission status. Then you don't need if sub_stats on line 152. Check the error_report child method to check if there any scenarios where the submission_status is returned.
| "|", | ||
| {"str_field": (str, ...), "int_field": (int, ...), "date_field": (dt.date, dt.date.today())}, | ||
| set(), | ||
| ), |
There was a problem hiding this comment.
add a test for checking headers with newline?
2 participants
No description provided.