Skip to content

CCM-17437: Zap update and bug fix#1067

Merged
nhsd-angel-pastor merged 3 commits into
releasefrom
bugfix/CCM-17437_zap
May 20, 2026
Merged

CCM-17437: Zap update and bug fix#1067
nhsd-angel-pastor merged 3 commits into
releasefrom
bugfix/CCM-17437_zap

Conversation

@nhsd-angel-pastor
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor commented May 13, 2026 •
edited
Loading

Summary

Updated zapproxy version, python and nodejs. Replaced hbs-cli and used handlebars instead. Checked that the security analysis works ok.

https://dev.azure.com/NHSD-APIM/API%20Platform/_build/results?buildId=505891&view=results

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

@nhsd-angel-pastor nhsd-angel-pastor marked this pull request as ready for review May 13, 2026 15:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

@nhsd-angel-pastor nhsd-angel-pastor changed the title Bugfix/ccm 17437 zap CCM-17437: Zap May 18, 2026
@gareth-allan gareth-allan self-assigned this May 18, 2026
Ian-Hodges
Ian-Hodges reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ian-Hodges Ian-Hodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any where we can see that the zap-report.xml is being generated correctly?

@gareth-allan
Copy link
Copy Markdown
Contributor

gareth-allan commented May 18, 2026 •
edited
Loading

Is there any where we can see that the zap-report.xml is being generated correctly?

I think we can see them in the Tests tab of the Azure DevOps pipeline:
Screenshot 2026-05-18 at 14 17 00

E.g. here: https://dev.azure.com/NHSD-APIM/API%20Platform/_build/results?buildId=505891&view=ms.vss-test-web.build-test-results-tab

gareth-allan
gareth-allan approved these changes May 18, 2026
View reviewed changes
Comment thread .tool-versions Outdated
@nhsd-angel-pastor
CCM-17437: updated versions
b80d12b 
nodejs version update
@nhsd-angel-pastor
CCM-17437: Updated zap version
33689aa
@nhsd-angel-pastor
CCM-17437: Enforcing glob-promise due using hbs-cli
0afa700 
Replace hbs-cli with handlers and added a script to replicate that
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-17437

@Ian-Hodges Ian-Hodges changed the title CCM-17437: Zap CCM-17437: Zap update and bug fix May 19, 2026
@nhsd-angel-pastor nhsd-angel-pastor merged commit 494a4f5 into release May 20, 2026
6 checks passed
@nhsd-angel-pastor nhsd-angel-pastor deleted the bugfix/CCM-17437_zap branch May 20, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ian-Hodges Ian-Hodges Ian-Hodges approved these changes

@gareth-allan gareth-allan gareth-allan approved these changes

Assignees

@gareth-allan gareth-allan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nhsd-angel-pastor @gareth-allan @Ian-Hodges