generated from NHSDigital/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/cdapi 95 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nhsd-jack-wainwright
wants to merge
35
commits into
feature/CDAPI-55
Choose a base branch
from
feature/CDAPI-95
base: feature/CDAPI-55
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/cdapi 95 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated lambda build to package for the correct architecture.
Also updated test-unit target to include all unit tests within src directory.
… system matches expected value
Also added additional unit tests to capture missing coverage around resource.py.
Also updated contract tests to account for new Bundle endpoint.
…he API gateway mock.
Also added logging to API Gateway Mock and improved error handling in lambda handler.
…rather than via nohup
…rom correct location
… API gateway format Also updated tests to account for new _status endpoint and new create Test Result path.
|
Preview Lambda: |
…aws-lambda-powertools
|
Preview Lambda: |
0260c3b to
39b5886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding additional validation logic to the Bundle endpoint.
Context
Begins to add required validation to the existing initial Bundle endpoint.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.