Skip to content

Conversation

@nhsd-jack-wainwright
Copy link
Collaborator

Description

Adding additional validation logic to the Bundle endpoint.

Context

Begins to add required validation to the existing initial Bundle endpoint.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Also updated lambda build to package for the correct architecture.
Also updated test-unit target to include all unit tests within src directory.
Also added additional unit tests to capture missing coverage around resource.py.
Also updated contract tests to account for new Bundle endpoint.
Also added logging to API Gateway Mock and improved error handling in lambda handler.
… API gateway format

Also updated tests to account for new _status endpoint and new create Test Result path.
@github-actions
Copy link

Preview Lambda: pr-feature-cdapi-95
Preview URL: https://feature-cdapi-95.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk

@github-actions
Copy link

Preview Lambda: pr-feature-cdapi-95
Preview URL: https://feature-cdapi-95.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant