[GPCAPIM-275]: Harmonise the Controller, Flask entry point and Provider System modules

[davidhamill1-nhs]

Description

Context

Type of changes

• Refactoring (non-breaking change)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would change existing functionality)
• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have followed the code style of the project
• I have added tests to cover my changes
• I have updated the documentation accordingly
• This PR is a result of pair or mob programming
• Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

---

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

• I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

[github-actions]

✅ Trivy gate: no Critical/High vulnerabilities.

Trivy Image Scan Summary

Image: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:feature-gpcapim-275-harmonise

Severity	Count
CRITICAL	0
HIGH	0
MEDIUM	0
LOW	1
UNKNOWN	0

Findings (top 50)

Severity	ID	Package	Installed	Fixed	Source
LOW	CVE-2026-1703	pip	25.3	26.0	Python

[DWolfsNHS]

Some general suggestions to consider on this PR:

• take a consistent approach to filing modules (e.g. provider_request.py) in their own subfolders with __init__.py
• consistent naming for the client modules? e.g. (provider_request.py to provider_client.py)
• separate file with example patient bundle in
• consistent application of fhir types
• common error class
• per discussion with @Vox-Ben, remove from __future__ import annotations: we're not likely to use Python 3.6

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Deployment Complete

• Preview URL: https://feature-gpcapim-275-harmonise.dev.endpoints.clinical-data-gateway.national.nhs.uk — Health endpoint
  • Smoke Test: ✅ Passed (HTTP 200)
• Proxy URL: https://internal-dev.api.service.nhs.uk/clinical-data-gateway-api-poc-pr-75
• ECS Cluster: ecs-cluster
• ECS Service: pr-feature-gpcapim-275-harmonise
• ALB Target: arn:aws:elasticloadbalancing:eu-west-2:900119715266:targetgroup/gpcapim-275-harmonise/ead51b821cde10e5