[GPCAPIM-255] Controller module#59

Open

Vox-Ben wants to merge 64 commits intomainfrom

feature/GPCAPIM-255_controller_integration_cherrypick

Commits on Jan 27, 2026

[GPCAPIM-254]: Lift and shift of lambda functionality in to a Flask app.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Lambda is no longer being used; move actions away from it.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Github not picking up unindented input

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Github not picking up unindented input

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Add type hinting

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Beginning of /patient/$gpc.getstructuredrecord endpoint.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Handle logic in request-specific class

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Move to handler class

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Update healthcheck endpoint to return simplier body.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Remove the lambda.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Clean up github actions.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Clean up.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Unit tests no loonger exist in the top level.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Correct content-type header.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Handle response object, rather than just pass back dict.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Correct content-type header for healthcheck.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Add error hanlding in app.

davidhamill1-nhs
authored and
Vox-Ben
committed
Revert "[GPCAPIM-254]: Force new deployment of ecs task in preview environment."

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Make it clear which version is deployed in the health endpoint.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Correct module name.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Use tech radars preferred alpine and run thorugh non-root user.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: APIM handles CSRF through its auth design; We don't have to.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Reduce fragility of code by pushing environment variable getting in to their own testable methods.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Reduce fragility of code by ensuring headers are correctly read.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Reduce fragility of code by ensuring NHS number is correctly read.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: CSRF alert will be disabled in SonarQube; we do not need to recognise it in the app.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Mock Request.geT_json() method by return the request_body as a dict.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Pytest, by default, runs all test_*.py files. Passing such a restrictive path reduces the ability to place test files within module directories.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Move print lines in to test covered functions to stop SonarQube complaining.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Make the behaviour of the payload more explicit.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Constants should be UPPERCASE for clarity.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: No longer SSP-from/SSP-to headers; moving towards ODS-from header.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: It's a numbers game.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Correct name of test.

davidhamill1-nhs
authored and
Vox-Ben
committed
[GPCAPIM-254]: Correct step name.

davidhamill1-nhs
authored and
Vox-Ben
committed
Change return type to flask response
Vox-Ben
committed
Refactor things to make ruff happy
Vox-Ben
committed
Pass the request body & multiple SDS calls
Vox-Ben
committed
Mypy happy, tests passing
Vox-Ben
committed
Tests passing. Maybe got too many tests.
Vox-Ben
committed
Trim some unnecessary unit tests
Vox-Ben
committed
Sort out docstrings
Vox-Ben
committed
Add tests for coverage
Vox-Ben
committed
Add tests for coverage
Vox-Ben
committed
Change GP Connect to GP provider
Vox-Ben
committed
Remove redundant parentheses
Vox-Ben
committed
Fix expected response
Vox-Ben
committed
Address review comments
Vox-Ben
committed
Integrate with real GpProviderClient
Vox-Ben
committed
Integrate API handler with controller
Vox-Ben
committed

Commits on Jan 28, 2026

Commits on Jan 30, 2026

Address review comments
Vox-Ben
committed