Add alpha integration environment workflow#123
Conversation
|
Deployment Complete
|
|
✅ Trivy gate: no Critical/High issues. Trivy IaC (Terraform) Summary
Findings (top 50)
|
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:gpcapim-194alphaint
✅ No vulnerabilities found. |
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:gpcapim-194alphaint
✅ No vulnerabilities found. |
neil-sproston
force-pushed
the
GPCAPIM-194alphaInt
branch
from
0caa22c to
9d898da
Compare
|
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow and Terraform var-file to stand up an “alpha-integration” preview-style environment intended to use external integration services rather than stubs.
Changes:
- Introduces a new GitHub Actions workflow to build/push an image, apply Terraform, deploy an Apigee proxy, and run test suites for the alpha-integration environment.
- Adds a new
alpha-int.tfvarsvar-file for the preview Terraform environment. - Updates
infrastructure/.gitignoreto allow the new var-file to be checked in.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
infrastructure/environments/preview/alpha-int.tfvars |
Adds alpha-integration-specific Terraform inputs (currently stubbed). |
infrastructure/.gitignore |
Un-ignores alpha-int.tfvars so it can be committed. |
.github/workflows/alpha-integration-env.yml |
New workflow to deploy and test the alpha-integration environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| provider_url = "stub" | ||
| provider_mtls_cert = "stub" | ||
| provider_mtls_key = "stub" | ||
|
|
||
| sds_url = "stub" | ||
| sds_api_token = "stub" | ||
|
|
||
| pds_url = "stub" | ||
| pds_api_token = "stub" | ||
| pds_api_secret = "stub" | ||
| pds_api_kid = "stub" |
There was a problem hiding this comment.
The new alpha-int.tfvars still sets all external integration endpoints/credentials to the literal string "stub". Given the PR description says alpha-integration should point at real external integration environments (not stubs), this var-file will deploy the ECS task with placeholder values and won’t achieve the intended integration wiring. Consider either (a) setting these to the actual integration URLs, and using secret-name references (or nulls) for credentials, or (b) omitting these overrides and relying on the non-stub defaults/inputs that the alpha-integration environment should use.
| TF_STATE_BUCKET: "cds-cdg-dev-tfstate-900119715266" | ||
| TF_STATE_KEY: "dev/preview/alpha-integration.tfstate" | ||
| BRANCH_NAME: "alpha-integration" | ||
| ALB_RULE_PRIORITY: "2000" |
There was a problem hiding this comment.
ALB_RULE_PRIORITY is hard-coded to 2000. The existing preview environment workflow derives priorities as (1000 + PR number), which will eventually produce 2000 at PR #1000, causing an ALB listener rule priority collision and Terraform apply failures. To avoid future collisions, pick a priority outside the preview range (e.g., a high reserved value near the ALB max) or adopt the same deterministic allocation scheme with a dedicated reserved slot for alpha-integration.
| ALB_RULE_PRIORITY: "2000" | |
| ALB_RULE_PRIORITY: "50000" |
Description
Initial workflow to provide alpha-integration environment
Context
The alpha-integration environment will point to external services integration environment as opposed to internal stub/mock endpoints. This workflow is to support that environment.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.