Skip to content

[NRL-1922] Fix up some Sonarqube issues#1154

Open
mattdean3-nhs wants to merge 18 commits intodevelopfrom
feature/made14-NRL-1922-refixup-sonarqube
Open

[NRL-1922] Fix up some Sonarqube issues#1154
mattdean3-nhs wants to merge 18 commits intodevelopfrom
feature/made14-NRL-1922-refixup-sonarqube

Conversation

@mattdean3-nhs
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs commented Feb 26, 2026

Following on from our Sonarqube project reset, a bunch of issues have been uncovered.

This PR fixes the following issues:

  • Global permissions in workflows
  • Broken regexes in dynamodb model
  • Use [[ instead of [ for conditions in shell scripts
  • Use Python language features instead of old Python classes
  • Remove hardcoded AWS regions in boto-based scripts (use env instead)
  • Remove old legacy changelog files
  • Add NOSONAR exclusion in code instead of exceptions in Sonarcloud
  • Mop up remaining lows and info-level issues
  • Sonar config issues

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 98af011389934e302f52cc7d49daecd291d3bc6d
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: be61f3f7f0650392408b89c492ef75d82226a9d9
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 0fb2969cf8fe07e312adf46430977021e7c8be66
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 5842fde2fe50c86b229d2cc3a9579ec970aa4553
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: ab1474e004080e074d859a22620af48e075337d2
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 146523a6ac416f57ee4f0a14c6701517f057861a
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 7649657a079e2c108fe6afda443f2976a0b4b4b2
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants