Skip to content

NRL-1948 use new permission model#1153

Open
anjalitrace2-nhs wants to merge 13 commits intodevelopfrom
NRL-1948-use-new-permission-model
Open

NRL-1948 use new permission model#1153
anjalitrace2-nhs wants to merge 13 commits intodevelopfrom
NRL-1948-use-new-permission-model

Conversation

@anjalitrace2-nhs
Copy link
Contributor

@anjalitrace2-nhs anjalitrace2-nhs commented Feb 25, 2026

When a request:

  • is missing the nhsd-connection-metadata OR nhsd-client-rp-details headers
  • specifies the ODS code in the NHSD-End-User-Organisation-ODS header AND the app id in the nhsd-nrl-app-id header

NRL will attempt to lookup pointer permissions using the new permissions model - <producer|consumer>/<app id>/<ods>.json in S3

There are no permissions set up here yet and it wouldn't yet do anything with our new shiny ones anyways!

This is deployed on my feature branch https://anjal-dev.api.record-locator.dev.national.nhs.uk if you'd like to have a play 🛝

No environment defaults or app-level permissions in scope yet

TODO

  • switch permissions lookup to lambda layer rather than s3
  • rename "new perms" -> "v2 perms"
  • manually test with postman
  • make unit testing better - will follow up in another PR

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: e7c8761aee20a368d7c89202d3763c4e4598a46d
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 1c876ed765d9a8180698147ab89f2d9d2c625c3d
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

…ssions in lambda layer rather than s3 (as we agreed)
@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: b00e987c8ff907cdc3a7ec809bf0ee22ff485e50
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: e6b8ec8ed2a0b962505fa9356420bafba1691a46
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 96e52f0f0765c3c6e688942f3780730cccdd4557
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 3c6d492efdc97bad9145d727eeb1098c7d910b09
URL: https://nrl1948-01ba47.api.record-locator.dev.national.nhs.uk/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants