Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
81c1c28
test: automated build for nmr-cli
NishaSharma14 Jan 4, 2024
59b17bb
skip testing
NishaSharma14 Jan 4, 2024
6ed8291
update context path
NishaSharma14 Jan 4, 2024
a28853e
update context path
NishaSharma14 Jan 4, 2024
f9499dc
update repo name
NishaSharma14 Jan 4, 2024
ef56a4a
uncomment old changes
NishaSharma14 Jan 4, 2024
4d3540f
update branch name
NishaSharma14 Jan 4, 2024
27d568a
feat: add automated build for nmr-cli
NishaSharma14 Jan 4, 2024
7da09f7
Merge branch 'dev-nisha' of https://github.com/NFDI4Chem/nmrkit into …
NishaSharma14 Jan 4, 2024
4707d98
fix: ignore lwreg in pylint
NishaSharma14 Jan 4, 2024
483ac8f
ignore lwreg in pylint
NishaSharma14 Jan 4, 2024
3b53f34
remove the ignore command
NishaSharma14 Jan 4, 2024
07f5afc
Merge branch 'development' of https://github.com/NFDI4Chem/nmrkit int…
NishaSharma14 Jan 4, 2024
e237621
build and push nmrkit
NishaSharma14 Jan 5, 2024
f7f8e42
fix: pull image from Docker Hub instead of
NishaSharma14 Jan 12, 2024
175a1ec
Merge pull request #71 from NFDI4Chem/dev-nisha
NishaSharma14 Jan 12, 2024
8a9d915
refactor: nmr-cli
hamed-musallam Jan 19, 2024
375c62f
feat: resurrect spectrum from publication string
hamed-musallam Jan 19, 2024
d90c2fc
Merge pull request #74 from NFDI4Chem/nmr-cli
vcnainala Jan 20, 2024
99f6986
feat: update nmr-load-save to version 0.28.0 (#75)
hamed-musallam Apr 22, 2024
cf46187
chore: update dependencies
hamed-musallam Mar 18, 2024
72a3a33
chore: update dependencies
hamed-musallam Apr 22, 2024
bed41c1
feat: update nmr-load-save to version 0.29.3
hamed-musallam Apr 22, 2024
913a4d5
feat: update docker image to playwright:v1.43.1-jammy
hamed-musallam Apr 22, 2024
ab9ce57
chore: update playwright to version 1.44.1
hamed-musallam Jun 7, 2024
eecf2e5
feat: update to nmr-load-save version 0.33.1
hamed-musallam Jun 7, 2024
aff2e8d
chore: update dependencies
hamed-musallam Nov 28, 2024
484f060
chore: update the playwright docker image
hamed-musallam Nov 28, 2024
f1df45d
feat: update nmr-load-save to version 2.1.0
hamed-musallam Nov 28, 2024
9e40ba8
Merge pull request #76 from NFDI4Chem/update-nmrcli
vcnainala Nov 28, 2024
1ab07e5
feat: update nmr-load-save to version 3.1.3
hamed-musallam Mar 12, 2025
308d4c8
chore: update dependencies
hamed-musallam Mar 12, 2025
2ce03a0
Merge pull request #77 from NFDI4Chem/update-nmr-cli-3.1.4
vcnainala Mar 12, 2025
d0dad50
chore: update dependencies
hamed-musallam Mar 26, 2025
2be8067
feat: update nmr-load-save to version 3.3.0
hamed-musallam Mar 26, 2025
d510131
feat: predict spectrum from mol using NMRShiftDB
hamed-musallam Jun 13, 2025
8e981d0
Merge pull request #79 from NFDI4Chem/shiftdb-prediction-to-nmrium
vcnainala Jun 13, 2025
67c17ac
feat: add support for selecting peak shape algorithm (lorentzian or g…
hamed-musallam Jun 13, 2025
104a5d8
refactor: change prediction default 'nbPoints' value to 256k
hamed-musallam Jun 16, 2025
6e352d5
feat: update nmr-load-save to version 3.6.0 (#82)
hamed-musallam Jul 17, 2025
3e1cc62
feat: migrate to nmrium-core and nmrium-core-plugins
hamed-musallam Jul 17, 2025
9c91ea1
chore: update dependencies
hamed-musallam Sep 5, 2025
806dae0
feat: update NMRium core packages
hamed-musallam Sep 5, 2025
9c0e0d4
chore(nmr-cli): update dependencies
hamed-musallam Oct 27, 2025
b9b2cbb
feat(nmr-cli): update NMRium core packages
hamed-musallam Oct 28, 2025
481441c
feat: auto processing 1d core functions
hamed-musallam Oct 31, 2025
d152538
feat: auto ranges detection core function
hamed-musallam Oct 31, 2025
a445d85
feat: auto processing 2d core functions
hamed-musallam Oct 31, 2025
376d8c3
feat: auto zones detection core function
hamed-musallam Oct 31, 2025
13754e6
refator: generateSpectrumFromRanges ranges type
hamed-musallam Nov 3, 2025
2d84e7e
feat: expose options for automatic processing and range/zone detection
hamed-musallam Nov 3, 2025
8f125be
Merge pull request #86 from NFDI4Chem/expose-nmrium-features
vcnainala Jan 13, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions .github/workflows/dev-build.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# This worklflow will perform following actions when the code is pushed to development branch:
# This worklflow will perform following actions when the code is pushed to the development branch:
# - Build the latest docker image in development which needs test to pass first.
# - Push the docker image to Docker Hub under namespace - nfdi4chem with tag:dev-latest.
#
Expand All @@ -16,7 +16,8 @@ on:
env:
DOCKER_HUB_USERNAME : ${{ secrets.DOCKER_USERNAME }}
DOCKER_HUB_PASSWORD : ${{ secrets.DOCKER_PASSWORD }}
REPOSITORY_NAME: nmrkit
NMRKIT_REPOSITORY_NAME: nmrkit
NMR_CLI_REPOSITORY_NAME: nmr-cli
REPOSITORY_NAMESPACE: nfdi4chem
RELEASE_TAG: dev-latest

Expand All @@ -27,7 +28,7 @@ jobs:
push_to_registry:
name: Push Docker image to Docker Hub
runs-on: ubuntu-latest
needs: test_and_lint
#needs: test_and_lint
steps:
- name: Check out the repo
uses: actions/checkout@v3
Expand All @@ -38,14 +39,26 @@ jobs:
username: ${{ env.DOCKER_HUB_USERNAME }}
password: ${{ env.DOCKER_HUB_PASSWORD }}

- name: Build and push Docker image
- name: Build and push nmrKit Docker image
uses: docker/build-push-action@v4
with:
context: .
file: ./Dockerfile
push: true
build-args: |
RELEASE_VERSION=dev-latest
tags: ${{ env.REPOSITORY_NAMESPACE }}/${{ env.REPOSITORY_NAME }}:${{ env.RELEASE_TAG }}
tags: ${{ env.REPOSITORY_NAMESPACE }}/${{ env.NMRKIT_REPOSITORY_NAME }}:${{ env.RELEASE_TAG }}
username: ${{ env.DOCKER_HUB_USERNAME }}
password: ${{ env.DOCKER_HUB_PASSWORD }}

- name: Build and push nmr-cli Docker image
uses: docker/build-push-action@v4
with:
context: ./app/scripts/nmr-cli/
file: ./app/scripts/nmr-cli/Dockerfile
push: true
build-args: |
RELEASE_VERSION=dev-latest
tags: ${{ env.REPOSITORY_NAMESPACE }}/${{ env.NMR_CLI_REPOSITORY_NAME }}:${{ env.RELEASE_TAG }}
username: ${{ env.DOCKER_HUB_USERNAME }}
password: ${{ env.DOCKER_HUB_PASSWORD }}
2 changes: 2 additions & 0 deletions app/scripts/nmr-cli/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
node_modules/
build/
10 changes: 7 additions & 3 deletions app/scripts/nmr-cli/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
# build the image ` docker build --tag nmr-cli . `
# run the container ` docker run -it nmr-cli bash `

FROM mcr.microsoft.com/playwright:v1.40.0-jammy
FROM mcr.microsoft.com/playwright:v1.56.1-noble

SHELL ["/bin/bash", "-o", "pipefail", "-c"]


WORKDIR /app

#ENV BASE_NMRIUM_URL=https://nmrium.nmrxiv.org/
ENV BASE_NMRIUM_URL=https://nmriumdev.nmrxiv.org/

ENV NMR_PREDICTION_URL=https://nmrshiftdb.nmr.uni-koeln.de/NmrshiftdbServlet/nmrshiftdbaction/quickcheck

COPY package.json ./
COPY package-lock.json ./
Expand All @@ -18,8 +19,11 @@ RUN npm install

COPY . ./

RUN npm run build

#install the nmr-cli as a global package
# for example, nmr-cli -u https://cheminfo.github.io/bruker-data-test/data/zipped/aspirin-1h.zip
# for example, nmr-cli parse-spectra -u https://cheminfo.github.io/bruker-data-test/data/zipped/aspirin-1h.zip
# nmr-cli predict -n "1H" --id 1 --type "nmr;1H;1d" --shifts "1" --solvent "Dimethylsulphoxide-D6 (DMSO-D6, C2D6SO)" -m $"\n Ketcher 6122516162D 1 1.00000 0.00000 0\n\n 16 17 0 0 0 0 0 0 0 0999 V2000\n 1.1954 -4.6484 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 2.9258 -4.6479 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 2.0622 -4.1483 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 2.9258 -5.6488 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 1.1954 -5.6533 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 2.0644 -6.1483 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 3.7902 -4.1495 0.0000 N 0 0 0 0 0 0 0 0 0 0 0 0\n 4.6574 -4.6498 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 3.7964 -6.1512 0.0000 N 0 0 0 0 0 0 0 0 0 0 0 0\n 4.6596 -5.6458 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 5.5228 -4.1488 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 5.5277 -6.1421 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0\n 6.3895 -4.6477 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0\n 5.5216 -3.1488 0.0000 O 0 0 0 0 0 0 0 0 0 0 0 0\n 7.2548 -4.1466 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 8.1215 -4.6455 0.0000 C 0 0 0 0 0 0 0 0 0 0 0 0\n 3 1 2 0 0 0 0\n 1 5 1 0 0 0 0\n 5 6 2 0 0 0 0\n 6 4 1 0 0 0 0\n 4 2 1 0 0 0 0\n 2 3 1 0 0 0 0\n 4 9 1 0 0 0 0\n 9 10 2 0 0 0 0\n 10 8 1 0 0 0 0\n 8 7 2 0 0 0 0\n 7 2 1 0 0 0 0\n 8 11 1 0 0 0 0\n 10 12 1 0 0 0 0\n 11 13 1 0 0 0 0\n 11 14 2 0 0 0 0\n 13 15 1 0 0 0 0\n 15 16 1 0 0 0 0\nM END"
RUN npm install . -g


Expand Down
167 changes: 0 additions & 167 deletions app/scripts/nmr-cli/bin/index.js

This file was deleted.

Loading
Loading