Skip to content

Conversation

@KivenJia
Copy link
Contributor

image image

@KivenJia KivenJia requested a review from nevstop August 29, 2025 08:11
@KivenJia KivenJia self-assigned this Aug 29, 2025
@nevstop nevstop changed the base branch from Dev202508 to main August 29, 2025 11:18
@nevstop
Copy link
Contributor

nevstop commented Aug 31, 2025

几个特别的问题:

  1. Example 中还有Enum 等两个example
image
  1. 名称上似乎不是很好懂,咋们的用户主要是中文用户,最好用更直观的名称,比如:

CSM API String to Enum
CSM API String to float
Enum to CSM API String

把 API String 或者 CSM API String 当作一个名词,整体的使用,简化用户的理解

@KivenJia KivenJia linked an issue Aug 31, 2025 that may be closed by this pull request
KivenJia and others added 3 commits September 1, 2025 15:30
Enum already integrated into examples

Co-Authored-By: NEVSTOP <8196752+nevstop@users.noreply.github.com>
# Conflicts:
#	API-String-Arugments-Support/CSM - Module VI Ref.vi
#	API-String-Arugments-Support/CSM - Query CSM VI Ref By API String.vi
#	CSM API String Arguments Support.vipb
#	Example/Get Module Configuration Example/Get Module Configuration Example.vi
#	Example/String to Enum Example.vi
#	Example/String(Float with Unit) To Float Example.vi
#	Example/Supported Datatype Examples/Test Cases - 2D Array in Cluster.vi
#	Example/Supported Datatype Examples/Test Cases - 2D Cluster Array.vi
#	Example/Supported Datatype Examples/Test Cases - API String Arguments Support(Variant).vi
#	Example/Supported Datatype Examples/Test Cases - Array Contains Cluster with Array.vi
#	Example/Supported Datatype Examples/Test Cases - Cluster Array.vi
#	Example/Supported Datatype Examples/Test Cases - Cluster Changed Value as Arguments.vi
#	Example/Supported Datatype Examples/Test Cases - Cluster.vi
#	Example/Supported Datatype Examples/Test Cases - Complex.vi
#	Example/Supported Datatype Examples/Test Cases - Datatype Check.vi
#	Example/Supported Datatype Examples/Test Cases - Empty String Check.vi
#	Example/Supported Datatype Examples/Test Cases - float.vi
#	Example/Supported Datatype Examples/Test Cases - timestamp.vi
#	testcases/testcase-Supported-Datatype/testcases/test - float.vi
Copy link
Contributor

@nevstop nevstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改冲突

@nevstop nevstop merged commit c140df9 into main Sep 1, 2025
3 checks passed
@nevstop nevstop deleted the 89-refactor-example branch September 1, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

refactor example

3 participants