Prototype for a new way to handle performance data#119
Draft
RincewindsHat wants to merge 2 commits intomainfrom
Draft
Prototype for a new way to handle performance data#119RincewindsHat wants to merge 2 commits intomainfrom
RincewindsHat wants to merge 2 commits intomainfrom
Conversation
added 2 commits
June 21, 2024 16:02
Member
Author
|
should close #118 |
Member
Author
|
@martialblog since we did not come up with a better solution until now, should we go down this way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements my current idea for a new interface for performance data handling.
The main advantages are a reasonable sanity checks for special cases (
InfandNan), almost having type safety and a reasonable interface for users.Perfdata value must now be created with new initializer functions (
NewPdvInt64, NewPdvUint64andNewPdvFloat64`), which, given a number, will create the corresponding Perfdata Value.Sadly I could not find a good way to make this generic and with restricted types, so encoding a data type in the initializer it is.
Would be interested to get some feedback on this.