Skip to content

More robust output handling #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martialblog merged 2 commits into from
Mar 27, 2026
Merged

More robust output handling #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
592a1f4
More robust output handling
martialblog Mar 24, 2026
ee4a13f
[squash] Add add unittests
martialblog Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions check_monit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ def print_output(status, count_ok, count_all, items):

if len(items):
for item in items:
s = "OK" if item['status'] == 0 else "CRITICAL"
print(' \\_ [{0}]: {1}'.format(s, item['name']))
print(' ' + item['output'])

s = "OK" if item.get('status') == 0 else "CRITICAL"
print(' \\_ [{0}]: {1}'.format(s, item.get('name', 'No Name')))
print(' {}' .format(item.get('output', 'None')))

def get_service_output(service_type, element):
# Service Type Filesystem
Expand Down
18 changes: 18 additions & 0 deletions test_check_monit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,24 @@ def test_return_plugin(self, mock_print):

mock_print.assert_has_calls(calls)

@mock.patch('builtins.print')
def test_return_plugin_with_no_output(self, mock_print):
actual = print_output(1, 2, 3, [{'name': 'foo', 'output': None, 'status': 1}])

calls = [mock.call('[WARNING]: Monit Service Status 2/3'),
mock.call(' \\_ [CRITICAL]: foo'),
mock.call(' None')]

mock_print.assert_has_calls(calls)

actual = print_output(1, 2, 3, [{'name': 'foo', 'status': 1}])

calls = [mock.call('[WARNING]: Monit Service Status 2/3'),
mock.call(' \\_ [CRITICAL]: foo'),
mock.call(' None')]

mock_print.assert_has_calls(calls)

class MainTesting(unittest.TestCase):

@mock.patch('builtins.print')
Expand Down